Repository navigation
ci: retry distribution artifact uploads once - #200
Merged
Merged
Conversation
A transient artifact service timeout on one upload fails the whole distribution build, and with it a release's publish. Each wheel, sdist and manifest upload now continues on error and, when it failed, uploads again under the same name, replacing anything the first attempt left behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub's artifact service sometimes times out creating an artifact, even after its own internal retries. One timed-out wheel upload then fails the whole distribution build, and with it a release's publish.
Changes
upload-artifactsteps (wheels, sdist and the release manifest) continues on error.overwrite: trueso it replaces anything the first attempt left behind.Verification
uploadoff, so these steps first run in a release build.make check-cipasses.