Repository navigation
fix(syntax): ALTER SHARE UNSET <name> is left to Snowflake - #52
Merged
Merged
Conversation
Snowflake parses ALTER SHARE v1 UNSET v1 and refuses the property after parsing (errno 1420); #51 refused it. Only a bare UNSET is refused now.
Contributor
Author
kvlonge
added a commit
that referenced
this pull request
Nov 5, 2026
Basis: main 0c8952e (PR #52), catalogue e5403c0, evidence c9e2a2a, parser tree 584e207. - 15 forms approved (security_admin 9, ddl 5, classes 1): forms whose catalogue findings were fixed in 71a66a7, re-reads of stale reviews, and SHOW forms whose receipts newly landed. - Not read: comment.column-is, pivot and select.select, which carry open parser withholds (identifier and alias quoting). Checker at 0c8952e: valid, 3476 forms, 0 problems; 1707 of 3348 verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a #51 regression B found: main refuses
ALTER SHARE v1 UNSET v1 ;, which Snowflake parses (receipt errno 1420, a check after parsing; the catalogue case sf.security_admin.alter-share.unset-tag.kee763a99f85f is observe). Only a bareUNSET ;is refused now.Checked against all 73 receipted ALTER SHARE cases: none Snowflake parsed is refused. The 14 remaining disagreements are raw-fallback acceptances of Snowflake syntax errors that predate #51.
Gate:
make check-merge RECORDER=0is running on 0c8952e; the result will be posted here.