Repository navigation
Parse a Snowflake CREATE DATABASE ROLE by name - #59
Merged
Merged
Conversation
Contributor
Author
|
Gate (D94) on 553656c, base main c793813:
|
kvlonge
force-pushed
the
fix/snowflake-create-database-role
branch
from
November 5, 2026 08:37
553656c to
6c645a0
Compare
CREATE [ OR REPLACE ] DATABASE ROLE [ IF NOT EXISTS ] <name> [ COMMENT = ... ] now gives a DATABASE ROLE create_object with no source, where it was rejected before. Snowflake parses COMMENT = <identifier> there too (errno 2002, after parsing), so the comment takes either. CREATE DATABASE ROLE ; and CREATE DATABASE ROLE CLONE v1 still create a database named ROLE.
kvlonge
force-pushed
the
fix/snowflake-create-database-role
branch
from
November 5, 2026 08:52
6c645a0 to
a398f2e
Compare
Contributor
Author
|
Re-gate (D94) on a398f2e, rebased onto main 45e21bd (#58, checker only; the parser is unchanged since c793813):
|
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the standing gap the auditor recorded after #56 (D118 c5b1f1e): the documented positive
CREATE DATABASE ROLE v1 ;(k2735786d526b, Snowflake-accepted) was rejected on every main since 497ad27.CREATE [ OR REPLACE ] DATABASE ROLE [ IF NOT EXISTS ] <name> [ COMMENT = … ]now parses to aDATABASE ROLEcreate_object with no source.COMMENT = m1there and fails it after parsing (errno 2002).CREATE DATABASE ROLE ;andCREATE DATABASE ROLE CLONE v1 ;still create a database named ROLE (fix(syntax): keep OR REPLACE and quoting on Snowflake database and schema clones #56).CREATE ALTER DATABASE ROLE v1(opaque, unchanged from main).The gate result will be posted here.