Repository navigation
Fix the 53 receipts #68 contradicted; keep USE SCHEMA name parts - #72
Merged
Merged
Conversation
…radictions (D141) The snapshot's case lists only reach receipts through catalogue forms, so a receipt on a retired or uncited case id never counted. The check now judges every current receipt by its statement (SQL, setup and session), with SQL from the citing case or from the hash-checked inputs of the run reports, and records receipt_contradictions and unjudged_receipts in the snapshot. diff fails on a contradiction the base did not have; documented (D113) ones go on their own non-failing line (D135), and existing ones are listed without failing. On catalogue 8c9639e and evidence a82d976, 4203044 -> cbe394e reports 53 new contradictions, including all 27 the D118 audit of #68 found, plus the 68 documented flips on their own line.
Snowflake receipts show the parser over-rejecting or over-accepting these statements since #68: - Routine arguments and RETURNS TABLE columns may omit their name or type; Snowflake parses them and fails semantically (90201, 90214), including for DEFINE (import 137). The routine argument check is removed and the untyped-column check of tables is limited to non-external tables. - SHOW GRANTS OF/TO/ON reads a trailing kind word as the name and takes an empty kind before ; or LIMIT. - ALTER DYNAMIC TABLE may omit the name before SET <property> =, take an empty UNSET TAG, a nameless SET TAG = '<value>', an empty row access policy column list and a string DROP SEARCH OPTIMIZATION target. - CREATE TASK takes dollar-quoted property values and name tag values, and refuses AFTER once EXECUTE AS USER was read. - CREATE EXPERIMENT may omit TYPE before FROM SPECIFICATION. - CREATE STAGE and FILE FORMAT options may be comma-separated. - Backtick-quoted identifiers are refused in faithful Snowflake modes. - CREATE OR ALTER / DEFINE SEQUENCE refuses a reserved name part.
USE SCHEMA "v1 Q" . v1 and USE SCHEMA "v1 Q.v1" parsed to the same tree, since the two parts were joined into one name with a single quoted flag. In faithful Snowflake modes the Use node now also lists the parts of a qualified name, each with its quoting (D118 on 58b3331).
# Conflicts: # crates/sqlquack-syntax/src/parser/_helpers/ddl/snowflake_show.rs
Contributor
Author
|
Landed via D94: main = abd037f (fast-forward from 8085c5b). Gate Coverage diff, main 8085c5b + D141 → head (catalogue 8c9639e, evidence a82d976, full receipt set):
Merge note: #76 reworked SHOW GRANTS OF/ON in snowflake_show.rs. I took C's version, which covers the same r68 cases, and dropped my duplicate helpers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #71 (D141 receipt-direct check), which this branch contains.
r68 (coordinator D141 follow-up). D141's check found 53 receipts that #68 (4203044 → cbe394e) newly contradicts, including the auditor's 27. All 53 now agree with their receipts:
Probe over all 59,153 receipted statements (catalogue 8c9639e, evidence a82d976): 98 statements fixed, 0 newly contradicted.
USE SCHEMA (D118 on 58b3331). The Use node now lists a qualified name's parts with their own quoting in faithful Snowflake modes, so
"v1 Q" . v1and"v1 Q.v1"differ.Gate result follows in a comment.