Repository navigation
Conversation
So that the browser playground can reuse them rather than copy them: - The policy and session option modules move from the sqlquack crate's analysis into sqlquack-rules::session (conversion_options, confirm_utc_session, session_conversion_options, parse_session and the profile matching), and BUILTIN_PROFILE moves with them. - within_budget moves into sqlquack-rules::conversion. - The schema-file parser moves into sqlquack-semantics as types::main::parse_schema, with SchemaError and DECLARABLE_OFFSETS; the CLI's load_schema reads the file and calls it. - Policy implements FromStr, validating text as load_policy does a file. Behaviour is unchanged; callers change only their imports.
- The engine runs in a Web Worker; stale replies are dropped. - Spans index by code point, tested with non-ASCII text before a span. - The page takes a policy file, Snowflake session parameters, --strict and --utc-session, through the shared session options, and reports the matched profile; the schema is read by the shared parse_schema. - Conversion is timed with performance.now against the policy's budget. - DuckDB-WASM 1.33.1-dev114.0 (DuckDB 2.0) is copied from node_modules at build time and served from the site. - The Website workflow also lints, builds and tests the engine, on pull requests and by hand; it never runs on push to main and never deploys.
Contributor
Author
|
Closing: this head is on main by fast-forward (see the landing comment above); GitHub did not mark it merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
sqlquack::analysisintosqlquack-rules::session;within_budgetmoves intosqlquack-rules::conversion; the schema-file parser moves intosqlquack-semanticsastypes::main::parse_schema;PolicyimplementsFromStr. Behaviour is unchanged; callers change only their imports.sqlquack-syntaxis untouched.website.ymlgaining pull-request and manual runs that build and test the engine (never on push to main, never deploys).