Repository navigation
Playground: tested examples, refusal caption, valid-but-untranslated state - #80
Merged
Merged
Conversation
The examples move into examples.js, shared with the engine tests, which now check that the first-load default and the translating examples pass every stage, and that each error example stops where it is meant to. The refused example (HASH, a known divergence) gets a caption saying why SQLQuack refuses rather than guesses. When the SQL parses and passes the Snowflake checks but is not translated, the results open with "Valid Snowflake SQL. Not translated to DuckDB: <reason>", stage 3 reads NOT TRANSLATED in amber instead of a red FAIL, its underline is amber, and stage 4 says nothing was translated. Parse and check failures stay red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Website-only. The examples move into examples.js and an engine test checks every example's stage outcome (the first-load default passes every stage). The HASH example gets a caption on why SQLQuack refuses rather than guesses. When SQL parses and passes the Snowflake checks but is not translated, the results open with "Valid Snowflake SQL. Not translated to DuckDB: ", stage 3 reads NOT TRANSLATED in amber, and stage 4 says nothing was translated; parse and check failures stay red. Stage notes are padded inside their panel and readable. Nothing deploys.