Repository navigation
Parse the remaining security_admin SHOW, DROP, DESCRIBE and ALTER forms - #81
Merged
Merged
Conversation
- SHOW AUTHENTICATION, INGRESS, PASSWORD and SESSION POLICIES take ON ACCOUNT or ON USER after LIKE; IN no longer follows LIMIT or FROM. - IN APPLICATION, IN DATABASE, IN SCHEMA and IN ORGANIZATION PROFILE may omit the name where Snowflake reads it so; APPLICATION ROLES and DATABASE ROLES accept a bare name. - SHOW CALLER GRANTS reads ON as SHOW GRANTS does and TO ROLE, DATABASE ROLE, DATABASE or a name; USER FUNCTIONS and USER PROCEDURES are Snowflake SHOW kinds. - OPENFLOW DATA PLANE INTEGRATIONS takes no clauses. - After IN ACCOUNT or ON ACCOUNT, a LIMIT that ends the statement is the account's name, as Snowflake reads it; DATABASES and SHARES IN FAILOVER GROUP, ROLES and ENDPOINTS IN SERVICE, and ROLES, FUNCTIONS and PROCEDURES IN CLASS may omit the name. - DROP and DESCRIBE gain the organization, profile, application role and snapshot policy kinds, and read a trailing kind word as the name when the shorter kind exists. - ALTER ORGANIZATION <name> RENAME TO is typed; ALTER ROW ACCESS, PRIVACY and PROJECTION POLICY are typed, and their incomplete kinds are rejected. Against main abd037f, 138 receipted cases now match Snowflake (ddl 30, security_admin 108) and none regress.
- ALTER SECRET is a resource kind with one SET action; its name follows the object-name rules, so a string, a bare reserved word or a missing SET is rejected as Snowflake rejects them. - ALTER RESOURCE MONITOR reads `[ SET <property> ... ] [ TRIGGERS ON <n> PERCENT DO <action> ... ]`, both optional, with CREATE's property and trigger items; an incomplete ALTER RESOURCE is rejected. - ALTER [ SECURITY ] INTEGRATION ... REFRESH names exactly one key: Snowflake rejects a bare REFRESH and SAML2_SNOWFLAKE_PRIVATE_KEY with METADATA_URL (recorded errno 1003). Against main abd037f, with the previous commit, 156 receipted cases now match Snowflake (ddl 30, security_admin 126) and none regress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parser batch for the remaining security_admin gaps (lane C's D133 slice).
ON ACCOUNT | ON USER <name>after LIKE. IN no longer follows LIMIT or FROM. Container names are optional where Snowflake allows it (APPLICATION, DATABASE, SCHEMA, ORGANIZATION PROFILE, FAILOVER GROUP, SERVICE, CLASS). A statement-ending LIMIT after IN or ON ACCOUNT is read as the account's name. Also SHOW CALLER GRANTS, USER FUNCTIONS and USER PROCEDURES, and the clause-less OPENFLOW DATA PLANE INTEGRATIONS.D94 gate on f93bd77 (base main d539bbe):
make check-merge RECORDER=0exit 0. Coverage diff: forms +25 / −0, obligations +218 / −0 (ddl +9/+30, security_admin +16/+188). Receipt scan: 224 cases newly rejected, none of which Snowflake parsed. Receipt harness over 54,040 receipted cases: 156 fixed, 0 broken.