Repository navigation
Conversation
pip install sqlquack installed only the Python module. A new sqlquack-cli distribution ships the native sqlquack executable, as sqlbuild-cli does for sqlbuild, and sqlquack depends on it at the same version. Both wheels compile DuckDB in, so they need no system DuckDB, and carry the licence and third-party notices, now including DuckDB's. Build, release and publish workflows follow SQLBuild's: wheels for Linux, macOS and Windows smoke tested with the site's quick start, and trusted publishing to PyPI. Release Please stays idle until the SQLQUACK_RELEASES repository variable is enabled at launch.
libduckdb-sys links the archive that calls duckdb_register_static_extensions after libduckdb, which defines it. GNU ld does not look back, so the bundled sqlquack binary failed to link on linux-aarch64. Both bundled targets now mark the loader undefined up front on Linux.
Contributor
Author
|
Superseded by #157, rebuilt on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The site says
pip install sqlquack, thensqlquack checkandsqlquack convert --builtin-policy. Thesqlquackwheel has only the Python module, with no command, and nothing in the repository builds or publishes distributions.Changes
sqlquack-clidistribution (crates/sqlquack/pyproject.toml, maturinbindings = "bin"): it ships the nativesqlquackexecutable, following SQLBuild'ssqlbuild/sqlbuild-clisplit.sqlquackdepends onsqlquack-cliat the same version, so onepip installgives both the module and the command.bundledfeature chain (sqlquack-duckdb → sqlquack → sqlquack-python) compiles DuckDB into both wheels, so they need no system DuckDB. Both wheels ship LICENSE and THIRD_PARTY_NOTICES, which now include DuckDB's MIT notice.make distribution-notices, part ofcheck-ci, keeps the copies equal.build-distributions.yml: wheels for Linux x86_64/aarch64, macOS x86_64/arm64 and Windows x86_64, plus sdists. Each wheel is smoke tested in a fresh venv with the site's quick-start commands.distributions.yml: runs that build on pull requests that touch packaging.release-distributions.yml,publish.yml(trusted publishing,pypienvironment, v0* tags only) andrelease-please.yml.SQLQUACK_RELEASESisenabled, so no release pull request, tag or upload can happen before launch.Verification
--no-index), then ransqlquack --version, the QUALIFY check (SQ0203, exit 1) andconvert --builtin-policy. The binary has no libduckdb dependency.make check-cipasses, and the hygiene scan is clean.