Repository navigation
refactor: define executor, CLI, auth and dev server shapes natively - #373
Merged
Merged
Conversation
Destruction, readiness, deployment, auditing, observability, janitor, reconcile, testing and doctor shapes, enums, exceptions and constants are native classes; the old modules re-export them. The destruction types module keeps its plan-store and planning-connection protocols and clock alias. Movable Python drops from 4784 to 3747 lines.
…e core CLI, auth, authorization, workflow, sensor error, dev server and diagnostic shapes, enums, exceptions and constants are native classes; the old modules re-export them. Account request bodies stay pydantic models that the native dev server validates, and the dev server types module keeps its protocols and type aliases. Movable Python drops from 3747 to 2685 lines.
Deploying sqltide with
|
| Latest commit: |
cd38bc0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a379fbb7.sqltide.pages.dev |
| Branch Preview URL: | https://wip-native-shapes-4.sqltide.pages.dev |
Deploying sqltide with
|
| Latest commit: |
cd38bc0
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python in SQLTide should be a thin wrapper; the native core already builds and reads these shapes.
Changes
REMOVEDin scripts/shape_surface/constants.py.remaining_lines4784→2685; 102 pure re-export files (728 lines) reported apart. New stays: rule 1executor/destruction/types.py(plan-store and planning-connection protocols, clock alias) anddev_server/types.py(authorization-guard and reporter protocols, Kafka type aliases); rule 4auth/models.py(pydantic request bodies the native dev server validates).Misuse-only messages
Generic CPython errors name the dotted type; native exception constructor TypeErrors are worded differently. Whether a call raises, the exception type and
.argsmatch.Introspection and subclassing of internal shapes
As in the previous shape release: no
vars()/__dict__, generic field types, annotations, signatures and docstrings, Python subclasses are not dataclass subclasses, and passing imports of old modules are gone (no docs or examples use them).Verification
make check-cion the final head; goldens unedited. Against 0.65.13: 6×1500 differential cases per slice match, including raise-or-not, exception type and.argsfor misuse calls; 30 planted mutations caught; 16 CLI project variants and 23 dev-server API responses identical after masking.