Repository navigation
fix(cli): report an unreachable ClickHouse endpoint without the driver's log line - #385
Merged
Merged
Conversation
…r's log line A refused connection or unresolvable host printed clickhouse_connect's own 'Unexpected Http Driver Exception' warning above SQLTide's error. SQLTide's message now carries what that line stood for, the endpoint and a short cause: Plan could not connect to ClickHouse at db.example.com:8123: connection refused The translated AdapterUnavailableError records the endpoint and reason, and a logging filter on the driver's HTTP client logger demotes that one line to DEBUG while a refused or unresolved connection is being handled: it is dropped unless DEBUG is enabled for the logger. Other driver records, and the same line for other transport failures, are unchanged. Refs: CHI-1214
…ures Follow-up to the unreachable ClickHouse message: - an IPv6 host is shown as [::1]:8123 rather than ::1:8123 - when urllib3 reports a ProxyError, the endpoint is the configured proxy, so the message reads 'could not connect to ClickHouse through proxy <host>:<port>' instead of naming the proxy as ClickHouse - a socket.gaierror with errno EAI_AGAIN is reported as a temporary DNS failure; other resolution errors stay 'host not found'. The errno is used, not the message text Refs: CHI-1214
Deploying sqltide with
|
| Latest commit: |
8fa5f38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c11a0842.sqltide.pages.dev |
| Branch Preview URL: | https://fix-refused-connection-log.sqltide.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When ClickHouse is unreachable, the CLI prints a clean error, but the ClickHouse client library still logs a bare "Unexpected Http Driver Exception" line above it. That line carries no host, port or cause and reads like a crash.
Changes
Plan could not connect to ClickHouse at 127.0.0.1:8123: connection refused,host not foundortemporary DNS failure. IPv6 hosts are bracketed and a refusing proxy is named as a proxy.endpointandreasonattributes; its message text is unchanged.Verification
Closes CHI-1214