Repository navigation
ci: give the static and unit job 30 minutes - #388
Merged
Merged
Conversation
A dependency install that misses the cache takes about 9 minutes, which left the unit tests cut off at the 20 minute limit on a release pull request.
Deploying sqltide with
|
| Latest commit: |
4b7da1b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83ed8646.sqltide.pages.dev |
| Branch Preview URL: | https://ci-unit-job-timeout.sqltide.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On a release pull request, the dependency install missed the cache and took about 9 minutes, so the "Static, UI, and unit checks" job hit its 20 minute limit while unit tests were still running. The re-run passed in 18.5 minutes, too close to the limit.
Changes
timeout-minutesfrom 20 to 30.Verification