Repository navigation
fix: console reply of sm_admins_reloadcfgoverride and config handle leak - #45
Merged
Merged
Conversation
Move the hard-coded chat, reply, menu and HUD messages into a phrase file with en, fr, ru, es, de, pt and chi (srcdslab/.github#5). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
Translation audit follow-up (srcdslab/.github#6). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the reload-reply and configuration cleanup changes.
No open issues 🎉
What changed in this PR
Fixes #44 by making configuration reload replies work from the server console and rcon, and preventing a handle leak when loading the override configuration fails. Builds on the translations introduced in #43.
Changes:
- Uses
CReplyToCommandfor translated reload success and failure messages. - Deletes the KeyValues handle before returning on configuration import failure.
- Bumps the plugin version to
2.1.12.
| File | Description |
|---|---|
addons/sourcemod/scripting/AdvancedAdminList.sp |
Fixes command replies and failed-load cleanup; updates the version. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44.
Stacked on #43, this plugin's translation PR: merge #43 first. GitHub then retargets this PR to
master; refresh it by mergingmaster(overlapping lines: keep this branch's side).Changes
sm_admins_reloadcfgoverridereplies withCReplyToCommand, so it works from the server console and rcon.LoadConfigOverridedeleteskvbefore returning when the file is missing.Checks
smtranslate check --languages en,fr,ru,es,de,pt,chi: 0 errors, 0 warnings.