Repository navigation
fix(translations): group target names - #70
Merged
Merged
Conversation
Move the hard-coded chat, reply, menu and HUD messages into a phrase file with en, fr, ru, es, de, pt and chi (srcdslab/.github#5). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
Translation audit follow-up (srcdslab/.github#6). Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The review did not surface a concern that needs action before approval.
No open issues 🎉
What changed in this PR
Addresses #69 on top of translation PR #68 by localizing group target names and restoring crosshair-based spray banning.
Changes:
- Uses nested translations for group targets while preserving plain player names.
- Enables argument-free
sm_bansprayfor in-game admins, retaining the console usage check. - Removes duplicate ban logging and bumps the plugin version to 3.2.15.
| File | Description |
|---|---|
| addons/sourcemod/translations/SprayManager.phrases.txt | Updated as part of this pull request. |
| addons/sourcemod/scripting/SprayManager.sp | Updated as part of this pull request. |
| addons/sourcemod/scripting/modules/module_commands.inc | Updated as part of this pull request. |
Review effort: Balanced
The code fixes move to their own PR, stacked on this one.
Rushaway
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #69. The code fixes are in #73, stacked on this PR: merge this one first.
Changes
{1:t}. The code passessTargetNamewhen it is a phrase key, and"_s", sTargetNamefor a plain player name. No phrase added.Checks
smtranslate check --languages en,fr,ru,es,de,pt,chi: 0 errors, 0 warnings.