Skip to content

fix: translate usage lines, permanent period, sm_delvip not found reply and log fields - #38

Open
Rushaway wants to merge 3 commits into
masterfrom
fix/audit-followup
Open

Rushaway wants to merge 3 commits into
masterfrom
fix/audit-followup

Conversation

@Rushaway

@Rushaway Rushaway commented Nov 1, 2026

Copy link
Copy Markdown
Member

Fixes #37.

Stacked on #36, this plugin's translation PR: merge #36 first. GitHub then retargets this PR to master; refresh it by merging master (overlapping lines: keep this branch's side).

Changes

  • The three usage replies use the existing USE phrase ("Use:") before the untranslated command syntax.
  • The "show more" item uses a new phrase, formatted for the viewing admin.
  • "Set Period" with a permanent time now prints a "set to permanent" message and log line. Dated periods are unchanged.
  • sm_delvip replies with a new "VIP player not found" phrase when the query returns no row.
  • LOG_VIP_ADDED now gets the duration in szDuration and the expiry date (or "Never") in szExpires, in the server language.
  • 4 phrases added (ADMIN_SET_PERMANENT, LOG_ADMIN_SET_PERMANENT, VIP_PLAYER_NOT_FOUND, SHOW_MORE), in all 7 languages.

Not changed

  • COMMAND_NO_ACCESS (addons/sourcemod/scripting/vip/CMD.sp:392): only used in commented-out code. Left as is.
  • FIND_THE_ID_FAIL is no longer used by the core but stays in the phrase file: other plugins can load vip_core.phrases.
  • The LangError fallback (addons/sourcemod/scripting/vip/AdminMenu.sp:319): only shown when times.ini has no entry for the client and server languages. It flags a config error.
  • The English replies of sm_vip_dump_cache (addons/sourcemod/scripting/vip/CMD.sp:307-369): developer debug command, only built with DEBUG_MODE.

Checks

  • Builds with spcomp 1.12 and the CI dependencies, no new warnings.
  • smtranslate check --languages en,fr,ru,es,de,pt,chi: 0 errors, 0 warnings.

Rushaway and others added 2 commits November 1, 2026 00:47
Add the missing fr, ru, es, de, pt and chi translations
(srcdslab/.github#5).

Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
…ly and log fields

Translation audit follow-up (srcdslab/.github#6).

Co-Authored-By: WareZ57 <7504466+WareZ57@users.noreply.github.com>
Base automatically changed from feat/translations to master November 2, 2026 07:51
The translation PR's version bump is already on master, so this branch bumps the version once more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant