Repository navigation
fix(easee_cloud): declare the coarse session counter (1.4.1) - #214
Merged
Merged
Conversation
Easee moves session energy in steps of about 1 kWh. FTW's energy record judged each step against the time since the last reading, and rejected those that landed moments later. On one home box it kept 10 of 24.3 kWh. The driver now says so with session_wh_coarse. Measured power came within 0.1 % of Easee's own total on three charges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 8 November 2026 an Easee charger delivered 24.3 kWh to the owner's car. FTW's energy record kept 10 of them.
Easee moves session energy in steps of about 1 kWh, in its own time.
session_whis cumulative, so FTW's ledger uses it as a counter and judges each step against the time since the previous reading. With the SignalR stream the readings come seconds apart, so a step lands as an impossible power and the ledger rejects it (invalid,counter_jump).Change
easee_cloud1.4.1 emitssession_wh_coarse = true.session_whitself stays: it is right for what a session delivered, and the car's level and notices read it. FTW's energy record uses measured power for this charger (paired Core PR).Open PRs that also touch this driver (#200, #183, #194, #189, #172, #159) will need a version bump past 1.4.1.
Evidence
Measured power against Easee's own session total on the owner's box:
make test-driver ID=easee_cloud: 42 passed, 15 skipped, including a new test that the field is declared andsession_whstays.make checkpasses.Not run on hardware: the change only adds a field.
🤖 Generated with Claude Code