Repository navigation
Conversation
Prices gains an optional vatPermille: the VAT rate the box taxed totalMinor at, in permille (250 is 25 %). Absent means an older box and an unknown rate; 0 means no VAT. The protocol doc says so, and the simulated box sends the rate its own totals use. No UI change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | 2157f9c | Commit Preview URL Branch Preview URL |
Nov 01 2026, 02:17 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pair: srcfl/ftw#1949 (Core sends the field, and FTW Cloud's tile carries it). Merge the two together.
price.get's answer gainsvatPermille: the VAT rate the box taxedtotalMinorat, in permille (250 is 25 %). With it a client can show spot with VAT,spotMinor × (1 + vatPermille / 1000), at the box's own rate instead of a guess.docs/protocol.md: the field, what 0 and absent mean, and that a total stored before a rate change keeps the old rate for a while.src/lib/protocol/messages.ts:vatPermille?: numberonPrices. Optional, because an older box leaves it out, and absent means unknown, never zero.src/lib/sim/box.ts: the simulated box sends the rate its own totals use (25 % as 250).SIM_VAT_PCTis now exported from the sim planner for that.tests/price-e2e.test.ts: the sim names 250, and taking each total back out at that rate leaves the same tariff in every hour. A wrong rate would leave a tariff that follows the market.No UI change. No registry change: price message keys are not in
registry.yaml.Permille rather than a float percent because every ratio on the wire is an integer in permille, and the price answer keeps floats off the wire.
Tests, run on this machine:
npm run verify: pass (svelte-check 0 errors, 1190 tests, build)npm run check:contractagainst the paired FTW branch: registry and push catalogue match byte for byte🤖 Generated with Claude Code