Repository navigation
fix(drivers): bundle growatt 2.1.3, a PV-only Growatt shows no battery - #1973
Merged
Merged
Conversation
srcfl/device-drivers#203 skips the battery emit when every battery reading is 0, so a PV-only Growatt no longer draws a phantom battery beside the site's real one (#1669). The pin moves e463c653 to e07d2703; growatt is the only bundled driver that changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Growatt inverter with no battery (PV only) answers its battery registers with 0, and growatt 2.1.2 emitted a battery on every poll anyway. Overview then drew a second battery at 0 W and 0 % beside the site's real one (#1669). Two sites with a Growatt for PV and a Pixii battery reported it; one ran a local copy of the driver with the battery emit removed.
Change
Move the bundled-driver pin from e463c653 to e07d2703, which carries srcfl/device-drivers#203 (growatt 2.1.3): the driver emits a battery only when its voltage, charge level, charge power or discharge power is above 0. growatt is the only bundled driver that changes across the pin (
make driver-versions-across-pinpasses); the other two upstream commits add and fix a SAJ driver FTW does not bundle.The Growatt meter stays. Core counts only the site meter's reading in the power balance (
telemetry/forecast.go), so a Growatt meter at 0 W does not change Home use.Evidence
TestGrowattEmitsABatteryOnlyWhenOneAnswersruns the bundled driver through the real Lua host with a fake Modbus device: PV only gives a PV reading of −2 500 W and no battery; a hybrid at 50 % and a battery at 0 % with 52 V both give a battery. With growatt 2.1.2 the PV-only case fails with a battery at 0 W and SoC 0.make checkpasses on feat(loadpoint,easee): 1Φ/3Φ auto-switching with per-phase fuse clamp #203 merged with current main (5 089 passed), and its three harness tests fail on the old driver for the PV-only case.drivers-betafrom e07d2703.make verifypasses on this machine.Fixes #1669.
🤖 Generated with Claude Code