Skip to content

Avoid logging OAuth credentials in response bodies - #6

Open
econstantin wants to merge 1 commit into
sstallion:masterfrom
econstantin:codex/fix-oauth-response-logging
Open

econstantin wants to merge 1 commit into
sstallion:masterfrom
econstantin:codex/fix-oauth-response-logging

Conversation

@econstantin

Copy link
Copy Markdown

The REST client's DEBUG log currently includes raw response bodies, exposing authorization codes, access tokens, and refresh tokens returned by /oauth/authorize, /oauth/accesstoken, and /oauth/token.

Replace response-body logging with HTTP status logging. Response decoding, returned data, exception payloads, and HTTP behavior remain unchanged. Add synthetic regression tests for successful OAuth responses, JSON and malformed error responses, unread responses, and session construction and cleanup.

Wire version-matched OpenAPI Generator 7.8.0 templates into generate.sh so regeneration preserves the fix. The REST template retains the existing pool-manager customization; the matching configuration template preserves its constructor argument and attribute. Include an Unreleased changelog entry.

Verification

All local tests ran on Python 3.11, without real credentials or live SensorPush requests:

  • Focused regression tests: 18 passed.
  • Full suite with coverage (pytest --cov=sensorpush_api -q): 53 passed.
  • Fresh offline generation of rest.py and configuration.py together with OpenAPI Generator 7.8.0, the repository options, and a synthetic specification: 53 tests passed against the regenerated pair in an isolated package copy. Generated REST source matches the checked-in file; generated configuration differs only in existing SDK version metadata.
  • pip check, sh -n generate.sh, and git diff --check: passed.

The broader Python CI matrix has not been run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant