Repository navigation
Avoid logging OAuth credentials in response bodies - #6
Open
econstantin wants to merge 1 commit into
Open
econstantin wants to merge 1 commit into
econstantin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST client's DEBUG log currently includes raw response bodies, exposing authorization codes, access tokens, and refresh tokens returned by
/oauth/authorize,/oauth/accesstoken, and/oauth/token.Replace response-body logging with HTTP status logging. Response decoding, returned data, exception payloads, and HTTP behavior remain unchanged. Add synthetic regression tests for successful OAuth responses, JSON and malformed error responses, unread responses, and session construction and cleanup.
Wire version-matched OpenAPI Generator 7.8.0 templates into
generate.shso regeneration preserves the fix. The REST template retains the existing pool-manager customization; the matching configuration template preserves its constructor argument and attribute. Include an Unreleased changelog entry.Verification
All local tests ran on Python 3.11, without real credentials or live SensorPush requests:
pytest --cov=sensorpush_api -q): 53 passed.rest.pyandconfiguration.pytogether with OpenAPI Generator 7.8.0, the repository options, and a synthetic specification: 53 tests passed against the regenerated pair in an isolated package copy. Generated REST source matches the checked-in file; generated configuration differs only in existing SDK version metadata.pip check,sh -n generate.sh, andgit diff --check: passed.The broader Python CI matrix has not been run locally.