Repository navigation
Rework Feature Flags - #401
Open
Bohreromir wants to merge 3 commits into
Open
Bohreromir wants to merge 3 commits into
Bohreromir wants to merge 3 commits into
Conversation
|
|
Bohreromir
force-pushed
the
worktree-chore-372-377-feature-flags-helm
branch
from
October 23, 2026 14:30
cca36e1 to
b5085de
Compare
…lags (#372) Limits and tuning move out of the feature-flag modules into $lib/client/config (PUBLIC_) and $lib/server/storage/config. All values are parsed with zod; invalid values stop the server at startup with an error that names them, instead of silently falling back to defaults. The config is imported in hooks.server.ts so it is checked at boot. The legacy alias PUBLIC_STACKABLE_UI_STORAGE_RESTORE_TABS is dropped and boolean flags only accept true or false.
… tab restore (#372) PUBLIC_STACKABLE_COCKPIT_STORAGE_TRANSFER_ENABLED replaces the cut/copy, paste, rename and move flags in the file browser and on the transfer endpoint. Cut/copy alone had no effect, and the endpoint already treated the remaining flags as one cost-control switch. Infinite scroll and tab restore no longer have flags and are always on; the fixed-row CSV and Parquet preview mode is removed. BREAKING CHANGE: PUBLIC_STACKABLE_COCKPIT_STORAGE_{CUT_COPY,PASTE,RENAME,MOVE}_ENABLED, PUBLIC_STACKABLE_COCKPIT_INFINITE_SCROLL_ENABLED and PUBLIC_STACKABLE_COCKPIT_STORAGE_RESTORE_TABS are removed.
…vFrom (#372, #377) features now only holds toggles: trino.completion.enabled, storage.enabled and the new storage.transfer. Storage limits and tuning, including archiveCacheMaxMb (previously config.archiveCacheMaxMb), move to the top-level storage block. Values are passed through unchanged for the application to validate: 0 and false are no longer dropped, and only whole numbers are converted to integers. extraEnv and extraEnvFrom pass additional environment variables to the container. Closes #377
Bohreromir
force-pushed
the
worktree-chore-372-377-feature-flags-helm
branch
from
October 23, 2026 14:42
b5085de to
8b3a8ee
Compare
Bohreromir
marked this pull request as ready for review
October 23, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PUBLIC_STACKABLE_COCKPIT_STORAGE_RENAME_ENABLEDandPUBLIC_STACKABLE_COCKPIT_STORAGE_MOVE_ENABLEDhappy to be corrected on any decision regarding thatCloses #372, #377
Docs
Release note
Checklist
Author
Reviewer
Acceptance