fix: Correct managed-by label value (.com → .tech) - #795
Open
adwk67 wants to merge 9 commits into
Open
Conversation
adwk67
marked this pull request as ready for review
August 13, 2026 15:08
adwk67
force-pushed
the
fix/unversioned-restserver-labels
branch
from
August 14, 2026 17:02
411da9c to
83ca24e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming of the operator name from hbase.stackable.com to hbase.stackable.tech
The rest of this PR was already covered by #799.
This also fixes the smoke test where #799 did not take env-var ordering into account.
Switch to unversioned labels for the Rest server- this is also breaking: existing rest-server STSs must be deleted before they can be reconciled by the new operator- the labels have not simply been unversioned (by setting the version to something neutral, such as "none") but are now assigned the role group selector labels plus the vendor one i.e.managed-byhas been dropped too, as done with HDFS.### For reviewers:- I am not sure droppingmanaged-byis the right thing to do. Here is what has happened to the three labels to consider:-version: this one has been removed-managed-by: this one has gone as well, following the pattern used in HDFS https://github.com/stackabletech/hdfs-operator/blob/main/rust/operator-binary/src/controller/build/resource/statefulset.rs#L83-L88.- HDFS is the relevant comparison because HBase and HDFS are the only operators whose listener volumes reference a ListenerClass (the listener-operator creates the Listener and copies the PVC labels onto it; all other operators create named group Listeners themselves)-vendor: this one has been retained: it is not included in the role-group selector labels, but was re-added manually to the set.Alternatively, we could opt for unversioned labels and pass "none" for the version instead, thus retainingmanaged-by.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker