Skip to content

fix: Correct managed-by label value (.com → .tech) - #795

Open
adwk67 wants to merge 9 commits into
mainfrom
fix/unversioned-restserver-labels
Open

fix: Correct managed-by label value (.com → .tech)#795
adwk67 wants to merge 9 commits into
mainfrom
fix/unversioned-restserver-labels

Conversation

@adwk67

@adwk67 adwk67 commented Aug 13, 2026

Copy link
Copy Markdown
Member

Description

Renaming of the operator name from hbase.stackable.com to hbase.stackable.tech

The rest of this PR was already covered by #799.

--- PASS: kuttl (815.98s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.6_hdfs-3.5.0_zookeeper-3.9.5_listener-class-cluster-internal_openshift-false (515.98s)
        --- PASS: kuttl/harness/smoke_hbase-2.6.6_hdfs-3.5.0_zookeeper-3.9.5_listener-class-external-unstable_openshift-false (299.99s)
PASS

This also fixes the smoke test where #799 did not take env-var ordering into account.

Switch to unversioned labels for the Rest server
- this is also breaking: existing rest-server STSs must be deleted before they can be reconciled by the new operator
- the labels have not simply been unversioned (by setting the version to something neutral, such as "none") but are now assigned the role group selector labels plus the vendor one i.e. managed-by has been dropped too, as done with HDFS.

### For reviewers:
- I am not sure dropping managed-by is the right thing to do. Here is what has happened to the three labels to consider:
- version: this one has been removed
- managed-by: this one has gone as well, following the pattern used in HDFS https://github.com/stackabletech/hdfs-operator/blob/main/rust/operator-binary/src/controller/build/resource/statefulset.rs#L83-L88.
- HDFS is the relevant comparison because HBase and HDFS are the only operators whose listener volumes reference a ListenerClass (the listener-operator creates the Listener and copies the PVC labels onto it; all other operators create named group Listeners themselves)
- vendor: this one has been retained: it is not included in the role-group selector labels, but was re-added manually to the set.

Alternatively, we could opt for unversioned labels and pass "none" for the version instead, thus retaining managed-by.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Aug 13, 2026
@adwk67
adwk67 marked this pull request as ready for review August 13, 2026 15:08
@adwk67
adwk67 force-pushed the fix/unversioned-restserver-labels branch from 411da9c to 83ca24e Compare August 14, 2026 17:02
@adwk67 adwk67 changed the title fix: Un-version pvc listener labels, correct operator name fix: Correct managed-by label value (.com → .tech) Aug 20, 2026
@adwk67
adwk67 requested a review from maltesander August 20, 2026 14:02

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants