Repository navigation
Conversation
The wrapper looked up the real compiler with bash read. read drops a trailing colon, and the loop passed over an empty entry, so the wrapper never searched the current directory. It reported a compiler that is only in the current directory as missing, and it ran a later copy when the current directory came first on PATH. An empty PATH entry is the current directory, including the entry a trailing colon names. execvp searches it, and rpath-wrappers already finds a compiler there through proc.which. The wrapper now splits PATH on colons and keeps every entry. An unset PATH still uses /bin:/usr/bin, the default command search path.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper looked up the real compiler with bash read. read drops
a trailing colon, and the loop passed over an empty entry, so the
wrapper never searched the current directory. It reported a
compiler that is only in the current directory as missing, and it
ran a later copy when the current directory came first on PATH.
An empty PATH entry is the current directory, including the entry
a trailing colon names. execvp searches it, and rpath-wrappers
already finds a compiler there through proc.which. The wrapper now
splits PATH on colons and keeps every entry. An unset PATH still
uses /bin:/usr/bin, the default command search path.