Repository navigation
Conversation
Tom's Obvious Minimal Language (TOML) allows 1_000 as one thousand. A single "_" may sit between two digits of a decimal integer. A leading zero, a doubled "_" and a "_" at either end of the digits stay invalid. The frozen Bash script reads legacy configuration keys and never parses a site-file integer. The Zig site parser follows the TOML grammar for decimal integers. Zig's parseInt accepts a doubled "_" that the grammar rejects, so the parser checks the grammar before it converts the value.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: accept digit grouping in site file integers
Tom's Obvious Minimal Language (TOML) allows 1_000 as one thousand. A
single "" may sit between two digits of a decimal integer. A leading
zero, a doubled "" and a "" at either end of the digits stay invalid.
The frozen Bash script reads legacy configuration keys and never parses
a site-file integer. The Zig site parser follows the TOML grammar for
decimal integers. Zig's parseInt accepts a doubled "" that the grammar
rejects, so the parser checks the grammar before it converts the value.