Skip to content

fix: validate from-commit EasyBuild versions - #232

Open
HaoZeke wants to merge 1 commit into
fix/explain-build-type-valuefrom
fix/from-commit-version-value
Open

HaoZeke wants to merge 1 commit into
fix/explain-build-type-valuefrom
fix/from-commit-version-value

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

With an eb-stack stub,
eb-pipeline check --list stack.yml --check-from-commit --easybuild-version $'5.4.0\n5.5.0'
exits 0 on main. Standard error contains
INFO [from-commit] -: running from-commit followed by
INFO [from-commit] -: from-commit passed.

cmd_check validates --easybuild-version before loading the list or
starting eb-stack. The reproducer exits 2 and writes
ERROR [main] -: --easybuild-version must be non-empty and contain no control characters
to standard error.

The new test
empty_or_control_easybuild_versions_fail_before_list_loading in
tests/from_commit_check.rs checks invalid --easybuild-version values
before list loading or helper execution.

With an `eb-stack` stub,
`eb-pipeline check --list stack.yml --check-from-commit --easybuild-version $'5.4.0\n5.5.0'`
exits 0 on main. Standard error contains
`INFO [from-commit] -: running from-commit` followed by
`INFO [from-commit] -: from-commit passed`.

`cmd_check` validates `--easybuild-version` before loading the list or
starting `eb-stack`. The reproducer exits 2 and writes
`ERROR [main] -: --easybuild-version must be non-empty and contain no control characters`
to standard error.

The new test
`empty_or_control_easybuild_versions_fail_before_list_loading` in
`tests/from_commit_check.rs` checks invalid `--easybuild-version` values
before list loading or helper execution.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant