Repository navigation
Conversation
With an `eb-stack` stub, `eb-pipeline check --list stack.yml --check-from-commit --easybuild-version $'5.4.0\n5.5.0'` exits 0 on main. Standard error contains `INFO [from-commit] -: running from-commit` followed by `INFO [from-commit] -: from-commit passed`. `cmd_check` validates `--easybuild-version` before loading the list or starting `eb-stack`. The reproducer exits 2 and writes `ERROR [main] -: --easybuild-version must be non-empty and contain no control characters` to standard error. The new test `empty_or_control_easybuild_versions_fail_before_list_loading` in `tests/from_commit_check.rs` checks invalid `--easybuild-version` values before list loading or helper execution.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an
eb-stackstub,eb-pipeline check --list stack.yml --check-from-commit --easybuild-version $'5.4.0\n5.5.0'exits 0 on main. Standard error contains
INFO [from-commit] -: running from-commitfollowed byINFO [from-commit] -: from-commit passed.cmd_checkvalidates--easybuild-versionbefore loading the list orstarting
eb-stack. The reproducer exits 2 and writesERROR [main] -: --easybuild-version must be non-empty and contain no control charactersto standard error.
The new test
empty_or_control_easybuild_versions_fail_before_list_loadingintests/from_commit_check.rschecks invalid--easybuild-versionvaluesbefore list loading or helper execution.