Repository navigation
Conversation
With a configured gap stub, `eb-pipeline check --site site.toml --gap-out gap --generation $'2026.1\n2026.2'` exits 0 on main. It writes `INFO [check] repro: site file is valid` to standard error and passes the control character to `eb-stack`. `cmd_check` validates `--generation` before loading the site. The reproducer exits 2 and writes `ERROR [main] -: --generation must be non-empty and contain no control characters` to standard error. The new test `empty_or_control_generations_fail_before_site_loading` in `tests/gap.rs` checks invalid `--generation` values before site loading or output creation.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a configured gap stub,
eb-pipeline check --site site.toml --gap-out gap --generation $'2026.1\n2026.2'exits 0 on main. It writes
INFO [check] repro: site file is validtostandard error and passes the control character to
eb-stack.cmd_checkvalidates--generationbefore loading the site. Thereproducer exits 2 and writes
ERROR [main] -: --generation must be non-empty and contain no control charactersto standard error.
The new test
empty_or_control_generations_fail_before_site_loadingintests/gap.rschecks invalid--generationvalues before site loadingor output creation.