Repository navigation
Conversation
`eb-pipeline run --site not-read.toml --list not-read.list --target cpu --build-type production --oom-preflight --node $'8:65536\n16:131072'` exits 2 on main. It writes `ERROR [main] -: cannot read not-read.toml: No such file or directory (os error 2)` to standard error, so the invalid `--node` value is not diagnosed. The run handler validates `--node` before reading inputs. The reproducer exits 2 and writes `ERROR [main] -: --node must be non-empty and contain no control characters` to standard error. The new test `run_refuses_empty_or_control_oom_nodes_before_input_loading` in `tests/schema_and_plan.rs` checks invalid `--node` values before input loading.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eb-pipeline run --site not-read.toml --list not-read.list --target cpu --build-type production --oom-preflight --node $'8:65536\n16:131072'exits 2 on main. It writes
ERROR [main] -: cannot read not-read.toml: No such file or directory (os error 2)to standard error, so the invalid
--nodevalue is not diagnosed.The run handler validates
--nodebefore reading inputs. The reproducerexits 2 and writes
ERROR [main] -: --node must be non-empty and contain no control charactersto standard error.
The new test
run_refuses_empty_or_control_oom_nodes_before_input_loadingintests/schema_and_plan.rschecks invalid--nodevalues before inputloading.