Skip to content

fix: validate OOM node option values - #234

Open
HaoZeke wants to merge 1 commit into
fix/gap-generation-valuefrom
fix/oom-node-option-value
Open

HaoZeke wants to merge 1 commit into
fix/gap-generation-valuefrom
fix/oom-node-option-value

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

eb-pipeline run --site not-read.toml --list not-read.list --target cpu --build-type production --oom-preflight --node $'8:65536\n16:131072'
exits 2 on main. It writes
ERROR [main] -: cannot read not-read.toml: No such file or directory (os error 2)
to standard error, so the invalid --node value is not diagnosed.

The run handler validates --node before reading inputs. The reproducer
exits 2 and writes
ERROR [main] -: --node must be non-empty and contain no control characters
to standard error.

The new test
run_refuses_empty_or_control_oom_nodes_before_input_loading in
tests/schema_and_plan.rs checks invalid --node values before input
loading.

`eb-pipeline run --site not-read.toml --list not-read.list --target cpu --build-type production --oom-preflight --node $'8:65536\n16:131072'`
exits 2 on main. It writes
`ERROR [main] -: cannot read not-read.toml: No such file or directory (os error 2)`
to standard error, so the invalid `--node` value is not diagnosed.

The run handler validates `--node` before reading inputs. The reproducer
exits 2 and writes
`ERROR [main] -: --node must be non-empty and contain no control characters`
to standard error.

The new test
`run_refuses_empty_or_control_oom_nodes_before_input_loading` in
`tests/schema_and_plan.rs` checks invalid `--node` values before input
loading.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant