Repository navigation
feat(select): group aliases and an exclude option for per-target line selection - #236
Merged
Merged
Conversation
… selection A build list can name a group of targets and carve out exceptions, as site lists with an include and an exclude option per line do. [targets.select] takes aliases, further tokens that name the target, and exclude_option, a second option whose tokens leave a line out. An exclusion takes priority over an inclusion, both options share the separator, and strip removes both. Validation refuses an alias that is empty, holds the separator or repeats value, and an exclude option that is malformed or equals option.
Inside a loaded EESSI stack the stub module environment printed the host's EESSI_CVMFS_REPO, so the watch tests probed the real repository and found a generation newer than their fixture's.
Tokens of a line are trimmed, so such an alias could never match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[targets.<name>.select]gains two keys:aliases[]exclude_optionA line is planned for a target when
optionnames it (byvalueor an alias), or is absentand
when_absent = "all", andexclude_optiondoes not name it. Exclusion wins when bothname the target.
strip = trueremoves both options beforeebsees the line.This is the selection a Jenkins build list already uses (
--include-systems=with machinegroup names,
--exclude-systems=), so a site file can describe it without a wrapper.Validation refuses an empty alias, an alias with surrounding whitespace, one that contains the separator or repeats
value,and an
exclude_optionthat is malformed or equal tooption.Also in this branch:
docs(site-file): the reference table lists the keys in schema order (the docs test compares them).test: the test runner drops the caller'sEESSI_*variables. Inside a loaded EESSI stackthe stub module environment printed the host's
EESSI_CVMFS_REPO, and 15watchtestsprobed the real repository and failed on a generation newer than their fixture's.
Checked
cargo fmt --all --check,cargo clippy --locked --all-targets -- -D warningsandcargo test --lockedpass with Rust 1.94.1 on a RHEL 9 node with an EESSI 2026.06environment loaded (the case the runner change is for).
Closes #235