Skip to content

feat(select): group aliases and an exclude option for per-target line selection - #236

Merged
HaoZeke merged 5 commits into
mainfrom
feat/select-exclude-and-aliases
Nov 19, 2026
Merged

HaoZeke merged 5 commits into
mainfrom
feat/select-exclude-and-aliases

Conversation

@HaoZeke

@HaoZeke HaoZeke commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

[targets.<name>.select] gains two keys:

Key Type Default Meaning
aliases array of string [] Further tokens that name this target, such as the name of a group of targets
exclude_option string none A second long option whose tokens leave a line out for this target

A line is planned for a target when option names it (by value or an alias), or is absent
and when_absent = "all", and exclude_option does not name it. Exclusion wins when both
name the target. strip = true removes both options before eb sees the line.

This is the selection a Jenkins build list already uses (--include-systems= with machine
group names, --exclude-systems=), so a site file can describe it without a wrapper.

Validation refuses an empty alias, an alias with surrounding whitespace, one that contains the separator or repeats value,
and an exclude_option that is malformed or equal to option.

Also in this branch:

  • docs(site-file): the reference table lists the keys in schema order (the docs test compares them).
  • test: the test runner drops the caller's EESSI_* variables. Inside a loaded EESSI stack
    the stub module environment printed the host's EESSI_CVMFS_REPO, and 15 watch tests
    probed the real repository and failed on a generation newer than their fixture's.

Checked

cargo fmt --all --check, cargo clippy --locked --all-targets -- -D warnings and
cargo test --locked pass with Rust 1.94.1 on a RHEL 9 node with an EESSI 2026.06
environment loaded (the case the runner change is for).

Closes #235

… selection

A build list can name a group of targets and carve out exceptions, as site
lists with an include and an exclude option per line do. [targets.select]
takes aliases, further tokens that name the target, and exclude_option, a
second option whose tokens leave a line out. An exclusion takes priority
over an inclusion, both options share the separator, and strip removes
both. Validation refuses an alias that is empty, holds the separator or
repeats value, and an exclude option that is malformed or equals option.
Inside a loaded EESSI stack the stub module environment printed the
host's EESSI_CVMFS_REPO, so the watch tests probed the real repository
and found a generation newer than their fixture's.
Tokens of a line are trimmed, so such an alias could never match.
@HaoZeke
HaoZeke merged commit d68b909 into main Nov 19, 2026
7 checks passed
@HaoZeke
HaoZeke deleted the feat/select-exclude-and-aliases branch November 19, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

select: a target cannot be named by a group, and a line cannot exclude a target

1 participant