Repository navigation
fix: refuse invalid JSON from eb-stack stack from-commit - #237
Merged
Merged
Conversation
With `--check-from-commit`, eb-pipeline passed the standard output of `eb-stack stack from-commit` through without parsing it. When eb-stack exited zero but wrote a broken document, the check still reported success. A caller reading the JSON (JavaScript Object Notation) then got a truncated document and exit status 0. The check now parses that output and fails when it does not parse. It uses the shared JSON reader in src/exit.rs, split so the reader also takes bytes from a pipe. The integration test replaces eb-stack with a stub that prints a lone opening brace and records its arguments. It checks the forwarded `stack from-commit --easystack PATH --json` and the failing exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: refuse invalid JSON from eb-stack stack from-commit
With
--check-from-commit, eb-pipeline passed the standard output ofeb-stack stack from-committhrough without parsing it. When eb-stackexited zero but wrote a broken document, the check still reported
success. A caller reading the JSON (JavaScript Object Notation) then
got a truncated document and exit status 0.
The check now parses that output and fails when it does not parse. It
uses the shared JSON reader in src/exit.rs, split so the reader also
takes bytes from a pipe.
The integration test replaces eb-stack with a stub that prints a lone
opening brace and records its arguments. It checks the forwarded
stack from-commit --easystack PATH --jsonand the failing exit.