Repository navigation
refactor(proc): share executable-file probe in which - #36
Merged
Merged
Conversation
`proc.which` checks each PATH candidate with an inline sequence of the `sys.z` conversion and `faccessat(X_OK)` followed by a regular-file stat. The private helper `isExecutableFile` holds that probe, and `which` calls it for each candidate, so a later resolver can share the same check. The behaviour of `which` stays the same. `src/proc.zig` holds no direct `which` test, and the PATH lookup case of the `resolveExecutable` test in the following commit runs through it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proc.whichchecks each PATH candidate with an inline sequence of thesys.zconversion andfaccessat(X_OK)followed by a regular-filestat. The private helper
isExecutableFileholds that probe, andwhichcalls it for each candidate, so a later resolver can share thesame check.
The behaviour of
whichstays the same.src/proc.zigholds no directwhichtest, and the PATH lookup case of theresolveExecutabletestin the following commit runs through it.