Repository navigation
test(proc): share executable fixture setup in resolver tests - #38
Merged
Merged
Conversation
The `resolveExecutable` test in `src/proc.zig` builds its scratch directory with an executable script and a plain file inline, and the resolver tests that follow need the same pair. The test-only helper `makeExecFixture` creates a pid-unique directory under `.zig-cache` holding `tool.sh` with mode 0755 and `plain.txt` with mode 0644, and returns the three paths. The existing test `resolveExecutable resolves slash paths and PATH lookup` in `src/proc.zig` calls `makeExecFixture` and keeps its assertions unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resolveExecutabletest insrc/proc.zigbuilds its scratchdirectory with an executable script and a plain file inline, and the
resolver tests that follow need the same pair. The test-only helper
makeExecFixturecreates a pid-unique directory under.zig-cacheholding
tool.shwith mode 0755 andplain.txtwith mode 0644, andreturns the three paths.
The existing test
resolveExecutable resolves slash paths and PATH lookupinsrc/proc.zigcallsmakeExecFixtureand keeps its assertionsunchanged.