Repository navigation
batching: Fix missed batch result watches - #152
Merged
Merged
Conversation
A batch result can be written to etcd while the waiting caller
still does not receive the watch event. This has been seen with
Cumulus 5 trunk configuration using many VLAN subports, where the
result key was written but the waiting caller still timed out
waiting for the watch event.
When this happens, the caller waits until the full batch timeout and
fails even though the result key exists. Use shorter watch waits and
check etcd between them so missed watch events do not cause false
batch timeouts.
Conflicts:
networking_generic_switch/batching.py
2025.1 has no "import threading"; added only "import time".
Assisted-By: openai codex gpt 5.5
Closes-Bug: #2152047
Change-Id: Ifa6b4a3ec447712c0ccf9fe0b79f8236be0ce33e
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
(cherry picked from commit 2306676)
mnasiadka
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A batch result can be written to etcd while the waiting caller still does not receive the watch event. This has been seen with Cumulus 5 trunk configuration using many VLAN subports, where the result key was written but the waiting caller still timed out waiting for the watch event.
When this happens, the caller waits until the full batch timeout and fails even though the result key exists. Use shorter watch waits and check etcd between them so missed watch events do not cause false batch timeouts.
Conflicts:
networking_generic_switch/batching.py
2025.1 has no "import threading"; added only "import time".
Assisted-By: openai codex gpt 5.5
Closes-Bug: #2152047
Change-Id: Ifa6b4a3ec447712c0ccf9fe0b79f8236be0ce33e
(cherry picked from commit 2306676)