Update workflows to run with 2026.1 - #2555
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughUpdated five CI workflows to define WalkthroughChangesVault password environment configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to The workflows now expose the Vault password to every step rather than only the tasks that need it, increasing the impact of any compromised action or command. Merge should wait for step-scoped secret usage or explicit security-owner acceptance. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f0c4aa8a-ddbf-4e53-93bf-ee0c4fb1aa0d
📒 Files selected for processing (5)
.github/workflows/amphora-image-promote.yml.github/workflows/ipa-image-build.yml.github/workflows/ipa-image-promote.yml.github/workflows/overcloud-host-image-build.yml.github/workflows/overcloud-host-image-promote.yml
💤 Files with no reviewable changes (2)
- .github/workflows/overcloud-host-image-build.yml
- .github/workflows/ipa-image-build.yml
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: stackhpc/check
- GitHub Check: Ansible 2.19 lint with Python 3.12
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/overcloud-host-image-promote.yml
[warning] 2-133: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
.github/workflows/amphora-image-promote.yml
[warning] 2-70: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
.github/workflows/ipa-image-promote.yml
[warning] 2-145: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
In 2026.1 the vault password is required during bootstrapping control host task. Some of our workflows continued working, as the vault password environment variable was set globally in the workflow, others failed as we only set it on certain tasks. This change updates relevant workflows to set the vault password on tasks which run `kayobe`, and also removes any global definitions of it so we aren't passing it to other actions unnecessarily.
ee1070c to
a8d37cb
Compare
5b2edcf to
091050b
Compare
stackhpc_overcloud_dib_elementsevaluate to None - filter these out