Skip to content

Update workflows to run with 2026.1 - #2555

Draft
owenjones wants to merge 6 commits into
stackhpc/2026.1from
fix-promotion
Draft

Update workflows to run with 2026.1#2555
owenjones wants to merge 6 commits into
stackhpc/2026.1from
fix-promotion

Conversation

@owenjones

@owenjones owenjones commented Aug 26, 2026

Copy link
Copy Markdown
Member
  • Vault password is required during bootstrapping control host task. Some of our workflows continued working as the vault password environment variable was set globally in the workflow while others failed as we only set it on certain tasks.
  • Amphora promotion workflow was set to run on Ubuntu 22.04 - 24.04 needed for newer required python version.
  • DOCA OFED tags needed updating from 3.2.2 to 3.2.3 to be able to build modules.
  • Some items in stackhpc_overcloud_dib_elements evaluate to None - filter these out

@owenjones
owenjones requested a review from a team as a code owner August 26, 2026 13:44
@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 709eee81-dce4-43bb-8c37-8fe552365476

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Updated five CI workflows to define KAYOBE_VAULT_PASSWORD globally from the CI builder secret. Removed redundant task-level declarations. This supports 2026.1 control host bootstrapping and prevents failures caused by task-scoped Vault password configuration.

Walkthrough

Changes

Vault password environment configuration

Layer / File(s) Summary
Define workflow-level Vault password environment
.github/workflows/amphora-image-promote.yml, .github/workflows/ipa-image-promote.yml, .github/workflows/overcloud-host-image-promote.yml
The promotion workflows define KAYOBE_VAULT_PASSWORD from the CI builder secret at workflow level.
Use workflow-level Vault password in IPA builds
.github/workflows/ipa-image-build.yml
The x86_64 and aarch64 IPA build steps remove repeated step-level Vault password environment blocks.
Use workflow-level Vault password in overcloud builds
.github/workflows/overcloud-host-image-build.yml
The standard and aarch64 overcloud image build steps remove repeated step-level Vault password environment blocks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🟡 Moderate · up to ee107

The workflows now expose the Vault password to every step rather than only the tasks that need it, increasing the impact of any compromised action or command. Merge should wait for step-scoped secret usage or explicit security-owner acceptance.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f0c4aa8a-ddbf-4e53-93bf-ee0c4fb1aa0d

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa8c88 and ee1070c.

📒 Files selected for processing (5)
  • .github/workflows/amphora-image-promote.yml
  • .github/workflows/ipa-image-build.yml
  • .github/workflows/ipa-image-promote.yml
  • .github/workflows/overcloud-host-image-build.yml
  • .github/workflows/overcloud-host-image-promote.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/overcloud-host-image-build.yml
  • .github/workflows/ipa-image-build.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Review details
⏰ Context from checks skipped due to timeout. (2)
  • GitHub Check: stackhpc/check
  • GitHub Check: Ansible 2.19 lint with Python 3.12
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/overcloud-host-image-promote.yml

[warning] 2-133: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

.github/workflows/amphora-image-promote.yml

[warning] 2-70: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

.github/workflows/ipa-image-promote.yml

[warning] 2-145: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

Comment thread .github/workflows/amphora-image-promote.yml Outdated
@owenjones
owenjones marked this pull request as draft August 26, 2026 13:58
@owenjones
owenjones marked this pull request as ready for review August 26, 2026 14:03
@owenjones
owenjones marked this pull request as draft August 26, 2026 14:09
In 2026.1 the vault password is required during bootstrapping control
host task. Some of our workflows continued working, as the vault
password environment variable was set globally in the workflow, others
failed as we only set it on certain tasks.

This change updates relevant workflows to set the vault password
on tasks which run `kayobe`, and also removes any global definitions
of it so we aren't passing it to other actions unnecessarily.
@owenjones owenjones changed the title ci: Provide vault password to tasks ci: Update workflows to run with 2026.1 Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant