feat(web-player): use URL hash for channel deep links - #716
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Documentation previewThe documentation preview has been deployed for this pull request. |
Tubetrue01
pushed a commit
to Tubetrue01/rtp2httpd
that referenced
this pull request
Aug 18, 2026
## Summary Migrate player deep links from query parameters (`?channel_id=1`, `?channel_name=...`) to URL hash fragments (`stackia#5`, `#CCTV-1`). Hash-based navigation is more appropriate for SPAs and avoids sending routing state to the server. Related: stackia#698 ## Changes - **URL format**: Changed from `/player?channel_name=name` to `/player#name` (or `/player#id` when ambiguous) - **Deep link resolution**: `findDeepLinkChannel()` now reads from `window.location.hash` instead of query params - **Smart ID vs name selection**: Added `channelNameIsAmbiguous()` and `channelDeepLinkToken()` to choose the most readable yet unambiguous token - Prefers channel name for readability - Falls back to ID when name is non-unique or matches an ID - **Hash change listener**: Added `hashchange` event handler so back/forward navigation and manual hash edits switch channels - **URL sync**: `syncChannelDeepLink()` now rewrites the hash instead of query params - **Tests**: Removed e2e test for old query parameter format - **Documentation**: Updated guide to show new hash-based syntax and clarify matching rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate player deep links from query parameters (
?channel_id=1,?channel_name=...) to URL hash fragments (#5,#CCTV-1). Hash-based navigation is more appropriate for SPAs and avoids sending routing state to the server.Related: #698
Changes
/player?channel_name=nameto/player#name(or/player#idwhen ambiguous)findDeepLinkChannel()now reads fromwindow.location.hashinstead of query paramschannelNameIsAmbiguous()andchannelDeepLinkToken()to choose the most readable yet unambiguous tokenhashchangeevent handler so back/forward navigation and manual hash edits switch channelssyncChannelDeepLink()now rewrites the hash instead of query params