Skip to content

feat(albwaf): onboard albwaf custom rule group - #1533

Merged
SerseusWasTaken merged 5 commits into
mainfrom
feat/add-waf-custom-rule-group
Aug 19, 2026
Merged

feat(albwaf): onboard albwaf custom rule group#1533
SerseusWasTaken merged 5 commits into
mainfrom
feat/add-waf-custom-rule-group

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Adds albwaf custom rule group support

Relates to STACKITCLI-443

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken force-pushed the feat/add-waf-custom-rule-group branch 3 times, most recently from 9d59902 to b2fd762 Compare August 14, 2026 06:08
@SerseusWasTaken
SerseusWasTaken marked this pull request as ready for review August 14, 2026 06:08
@SerseusWasTaken
SerseusWasTaken requested a review from a team as a code owner August 14, 2026 06:08
Comment thread internal/cmd/beta/albwaf/albwaf.go Outdated
Comment thread internal/pkg/config/config.go Outdated
Comment thread internal/cmd/beta/albwaf/custom-rule-group/list/list.go Outdated
Comment thread internal/cmd/beta/alb-waf/custom-rule-group/list/list.go
Comment thread internal/cmd/beta/alb-waf/custom-rule-group/list/list.go
Comment thread internal/cmd/beta/albwaf/custom-rule-group/list/list.go Outdated
Comment thread internal/cmd/beta/albwaf/custom-rule-group/create/create.go Outdated
Comment thread internal/cmd/beta/albwaf/custom-rule-group/delete/delete.go Outdated
Comment thread internal/cmd/beta/albwaf/custom-rule-group/update/update.go Outdated
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/add-waf-custom-rule-group branch 2 times, most recently from 33b630c to ce8ebd3 Compare August 14, 2026 12:56
cgoetz-inovex
cgoetz-inovex previously approved these changes Aug 14, 2026
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/add-waf-custom-rule-group branch from 3e1c3e7 to ca6635e Compare August 19, 2026 07:52
@SerseusWasTaken
SerseusWasTaken enabled auto-merge (squash) August 19, 2026 09:12
@SerseusWasTaken
SerseusWasTaken merged commit cbe98f6 into main Aug 19, 2026
4 checks passed
@SerseusWasTaken
SerseusWasTaken deleted the feat/add-waf-custom-rule-group branch August 19, 2026 09:13
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/create 58.33% (+58.33%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/delete 32.26% (+32.26%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/describe 79.17% (+79.17%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/generate-payload 50.00% (+50.00%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/list 29.58% (+29.58%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/update 59.18% (+59.18%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils 100.00% (+100.00%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/alb-waf.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/create/create.go 58.33% (+58.33%) 48 (+48) 28 (+28) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/custom-rule-group.go 0.00% (ø) 9 (+9) 0 9 (+9)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/delete/delete.go 32.26% (+32.26%) 31 (+31) 10 (+10) 21 (+21) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/describe/describe.go 79.17% (+79.17%) 72 (+72) 57 (+57) 15 (+15) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/generate-payload/generate_payload.go 50.00% (+50.00%) 40 (+40) 20 (+20) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/list/list.go 29.58% (+29.58%) 71 (+71) 21 (+21) 50 (+50) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/update/update.go 59.18% (+59.18%) 49 (+49) 29 (+29) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils/utils.go 100.00% (+100.00%) 8 (+8) 8 (+8) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/generate-payload/generate_payload_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/alb-waf/custom-rule-group/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants