feat(manifest): add exact schema version routing - #88
Open
stacknil wants to merge 3 commits into
Open
Conversation
Owner
Author
|
Post-CI diff review completed at
The report/schema behavior change remains open for the required spaced review; it is intentionally not being merged immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-manifest/v1andrun-manifest/v2schema selectionWhy
The repository documents both strict v1 and current v2 run-manifest contracts, but readers previously had no executable selection policy. A consumer could therefore hard-code one schema or invent a newest-version fallback. This PR makes the embedded marker authoritative before shape validation.
This is intentionally a reader-side contract change. Artifact-diff workflow work remains out of scope.
How to validate
Local result before push: 216 tests passed; 29 committed artifacts matched regenerated output; all three validation commands selected the expected schema.
Design and risk
telemetry_lab.run_manifest_contract.RUN_MANIFEST_SCHEMA_REGISTRYis the single authoritative marker-to-schema mapping.select_run_manifest_schema()performs exact lookup before JSON Schema validation; the CLI is a thin adapter.run-manifest/v2; strict v1 and v2 schema files, generated artifacts, aggregate digests, and runtime dependencies are unchanged. Historical v1 inputs gain an explicit supported reader path. The CLI uses the existing dev-onlyjsonschemadependency.Screenshots / GIF
Not applicable; there is no UI change.