Skip to content

ROX-39429: Decrease window duration to 7 days - #116

Merged
msugakov merged 4 commits into
mainfrom
misha/ROX-39429-decrease-window
Nov 20, 2026
Merged

msugakov merged 4 commits into
mainfrom
misha/ROX-39429-decrease-window

Conversation

@msugakov

Copy link
Copy Markdown

Per ticket.

@msugakov
msugakov requested a review from janisz November 20, 2026 12:58
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Changed Defaults
    • The priority window now defaults to seven days instead of 30.
    • Default comment-count thresholds are now 1, 2, 12, 24, and 48 for Minor, Normal, Major, Critical, and Blocker priorities.
  • Documentation
    • Updated the documented threshold ranges and clarified that thresholds are minimum comment counts.
    • Updated the example to use a 30-day window.

The default priority thresholds now use 1, 2, 12, 24, and 48 comments. The priority window defaults to seven days. The README and priority tests reflect these values.

Changes: Priority defaults

Layer / File(s) Summary
Update priority defaults and documentation
cmd/junit2jira/priority.go, cmd/junit2jira/main.go, README.md
The default thresholds change to 1, 2, 12, 24, and 48, and the default priority window changes to seven days. The README updates the resulting comment-count ranges and examples.
Update threshold tests
cmd/junit2jira/priority_test.go
The tests add comment-count cases and update expected default priorities. They continue to check custom thresholds.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to 3d20f

This change shortens the default priority window to seven days and lowers the default comment thresholds to match. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive The description says only "Per ticket." It points to an external ticket but does not describe any part of the changeset. The check is lenient, but this text gives no meaningful information about the c… Add a short description of the change. For example, state that the priority window changes from 30 to 7 days, that the default thresholds change to 1, 2, 12, 24, and 48, and that the README and tests are updated to match.
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the primary change: the priority window duration is reduced to 7 days. The raw summary confirms the flag default changes from 30 to 7 days and the README documents a seven-day window, …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the primary change: the priority window duration is reduced to 7 days. The raw summary confirms the flag default changes from 30 to 7 days and the README documents a seven-day window, so the title matches the changeset. The ticket prefix is a reference, not noise that makes the title unclear.

Full details: Description check

Explanation

The description says only "Per ticket." It points to an external ticket but does not describe any part of the changeset. The check is lenient, but this text gives no meaningful information about the changes, such as the new 7-day window or the updated thresholds, so it is too generic to confirm relevance.

Resolution

Add a short description of the change. For example, state that the priority window changes from 30 to 7 days, that the default thresholds change to 1, 2, 12, 24, and 48, and that the README and tests are updated to match.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 8e125acc-26d1-45f9-a257-10ac5cd2c21b
Commits

Reviewing files that changed from the base of the PR and between e85922d and 3d20fec.

Files selected for processing: 4

  • README.md
  • cmd/junit2jira/main.go
  • cmd/junit2jira/priority.go
  • cmd/junit2jira/priority_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@msugakov
msugakov merged commit 771fe95 into main Nov 20, 2026
10 checks passed
@msugakov
msugakov deleted the misha/ROX-39429-decrease-window branch November 20, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants