Skip to content

Add s390x binary build support - #348

Merged
mclasmeier merged 2 commits into
mainfrom
add-s390x-binary-support
Nov 18, 2026
Merged

mclasmeier merged 2 commits into
mainfrom
add-s390x-binary-support

Conversation

@mclasmeier

@mclasmeier mclasmeier commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add s390x to the Makefile architecture allowlist so make build-linux-s390x works
  • Add linux/s390x build step and release artifact to the GitHub release workflow

No CGO or arch-specific code, so cross-compilation works out of the box.

This intentionally covers only the binary build — no s390x Docker image support is added. Several bundled tools in the Dockerfile (notably gcloud) don't ship s390x binaries, so container support would require a different approach.

Test plan

  • Verified make build-linux-s390x produces a valid ELF 64-bit S/390 binary

🤖 Generated with Claude Code

Allow building linux/s390x binaries via `make build-linux-s390x` and
include them in GitHub releases.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 6db6665 and 5774808.

Files selected for processing: 1

  • Makefile

No actionable comments were generated in the recent review.

Walkthrough

The build target now accepts s390x. The release workflow builds a Linux s390x binary and includes it in the GitHub Release files.

Changes: s390x Release Support

Layer / File(s) Summary
Build and publish the s390x binary
Makefile, .github/workflows/release.yml
The build target accepts s390x. The release workflow builds roxie-linux-s390x and includes it in the GitHub Release files.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: Minimal · previous review 6db66

This adds a Linux s390x binary to the build and release workflow. It does not change existing architectures, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "Add s390x binary build support" matches the main change. The Makefile build-% target now accepts s390x, and the release workflow builds and uploads a linux/s390x binary. The title is short,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "Add s390x binary build support" matches the main change. The Makefile build-% target now accepts s390x, and the release workflow builds and uploads a linux/s390x binary. The title is short, specific, and describes the primary intent of the pull request.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between fa874a3 and 6db6665.

Files selected for processing: 2

  • .github/workflows/release.yml
  • Makefile

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Makefile Resolved
Checking OS and ARCH independently accepted impossible combinations
such as darwin-s390x. Replace both checks with a single list of the
exact os-arch pairs we support.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mclasmeier
mclasmeier merged commit 0473448 into main Nov 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants