Repository navigation
Add s390x binary build support - #348
Conversation
Allow building linux/s390x binaries via `make build-linux-s390x` and include them in GitHub releases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Warning Review limit reachedThis review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Next included review available in 22 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Checking OS and ARCH independently accepted impossible combinations such as darwin-s390x. Replace both checks with a single list of the exact os-arch pairs we support. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
s390xto the Makefile architecture allowlist somake build-linux-s390xworksNo CGO or arch-specific code, so cross-compilation works out of the box.
This intentionally covers only the binary build — no s390x Docker image support is added. Several bundled tools in the Dockerfile (notably gcloud) don't ship s390x binaries, so container support would require a different approach.
Test plan
make build-linux-s390xproduces a valid ELF 64-bit S/390 binary🤖 Generated with Claude Code