Skip to content

chore: Harmonize INFRA_CI_TOKEN to INFRA_TOKEN - #357

Merged
tommartensen merged 1 commit into
mainfrom
tm/chore-replace-INFRA_TOKEN
Nov 19, 2026
Merged

tommartensen merged 1 commit into
mainfrom
tm/chore-replace-INFRA_TOKEN

Conversation

@tommartensen

@tommartensen tommartensen commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

This is to make future rotations of the INFRA_TOKEN easier by re-using the org secret.
I shared the org secret INFRA_TOKEN with this repo and will remove the INFRA_CI_TOKEN after merge.

Validation: Roxie image builds and pushes, and infra cluster can be created.

Summary by CodeRabbit

  • Chores
    • Updated the credentials used by development cluster creation and deletion workflows, as well as end-to-end test workflows. These changes affect internal automation; no user-facing behavior changes are included.

This is to make future rotations of the INFRA_TOKEN easier by re-using the org secret.
@tommartensen tommartensen self-assigned this Nov 19, 2026
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

Three GitHub Actions workflows now set INFRA_TOKEN from secrets.INFRA_TOKEN instead of secrets.INFRA_CI_TOKEN. The cluster deletion command is unchanged.

Changes: Workflow token updates

Layer / File(s) Summary
Update workflow token sources
.github/workflows/create-dev-cluster.yml, .github/workflows/delete-dev-cluster.yml, .github/workflows/e2e-tests.yml
Each workflow now sources INFRA_TOKEN from secrets.INFRA_TOKEN instead of secrets.INFRA_CI_TOKEN.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: mclasmeier

Merge Risk: Minimal · up to a14ff

This swaps the infrastructure token secret used by the dev-cluster create, delete and E2E workflows from the repository secret to the organization secret. No leftover references to the old secret were found, and callers inherit secrets. Before merging, confirm the organization secret is shared with this repository.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore: Harmonize INFRA_CI_TOKEN to INFRA_TOKEN" matches the main change. The three workflow files (create-dev-cluster, delete-dev-cluster, e2e-tests) switch from secrets.INFRA_CI_TOKEN to s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "chore: Harmonize INFRA_CI_TOKEN to INFRA_TOKEN" matches the main change. The three workflow files (create-dev-cluster, delete-dev-cluster, e2e-tests) switch from secrets.INFRA_CI_TOKEN to secrets.INFRA_TOKEN. The title names both secrets and the action taken, so a reviewer scanning history can identify the primary change. It is short, specific, and free of file lists or vague wording.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0473448 and a14ff55.

Files selected for processing: 3

  • .github/workflows/create-dev-cluster.yml
  • .github/workflows/delete-dev-cluster.yml
  • .github/workflows/e2e-tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@tommartensen
tommartensen enabled auto-merge (squash) November 19, 2026 08:56

@mclasmeier mclasmeier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved when CI is happy

@tommartensen
tommartensen merged commit 77110ba into main Nov 19, 2026
10 of 12 checks passed
@tommartensen
tommartensen deleted the tm/chore-replace-INFRA_TOKEN branch November 20, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants