You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: switch to org shared quay secrets for pushing roxie's image - #362
No actionable comments were generated in the recent review.
Walkthrough
The image build workflows now use different secrets for Quay.io login. The end-to-end workflows remove Quay.io login steps, and the e2e-tests workflow removes its INFRACTL environment variable.
This change switches CI image publishing to organization-shared Quay secrets and removes unneeded registry logins. No concrete defect was found. Confirm that the organization secrets are available to this repository before merging.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: the workflows now use organization-shared Quay secrets to push roxie's image. The raw summary confirms the login secrets switched in build-roxie-image.yml and docker-b…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the workflows now use organization-shared Quay secrets to push roxie's image. The raw summary confirms the login secrets switched in build-roxie-image.yml and docker-build.yml. It also shows removal of the Quay login and the INFRACTL variable in the e2e workflows. The title covers the primary change but not the removal of the INFRACTL variable or the e2e login steps, which is acceptable for a title. The title uses the conventional commit prefix and is specific.
Reviewing files that changed from the base of the PR and between 77110ba and b1b232a.
Files selected for processing: 4
.github/workflows/build-roxie-image.yml
.github/workflows/docker-build.yml
.github/workflows/e2e-tests-kind.yml
.github/workflows/e2e-tests.yml
Files with no reviewable changes: 2
.github/workflows/e2e-tests-kind.yml
.github/workflows/e2e-tests.yml
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
tommartensen
changed the title
chore: switch to org shared quay secrets for pushing and reading roxie's image
chore: switch to org shared quay secrets for pushing roxie's image
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olm-testsIf set, spawn an OpenShift cluster and run OLM tests against it.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quay.io/rhacs-eng/roxierepo is public)INFRACTLenv varSummary by CodeRabbit