Skip to content

chore: switch to org shared quay secrets for pushing roxie's image - #362

Open
tommartensen wants to merge 3 commits into
mainfrom
tm/harmonize-quay-secrets
Open

tommartensen wants to merge 3 commits into
mainfrom
tm/harmonize-quay-secrets

Conversation

@tommartensen

@tommartensen tommartensen commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator
  • Switches to org-provided secrets for Quay authentication
  • Removes superfluous quay logins for pulling roxie images (the quay.io/rhacs-eng/roxie repo is public)
  • Removes ineffective INFRACTL env var

Summary by CodeRabbit

  • Chores
    • Updated image build workflows to use the current Quay.io credentials.
    • Simplified end-to-end test workflows by removing Quay.io login steps. Tests continue to retrieve the required binaries and run.
    • These workflow changes affect build and test automation; no changes to end-user features or app behavior are included in this update.

@tommartensen tommartensen self-assigned this Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

The image build workflows now use different secrets for Quay.io login. The end-to-end workflows remove Quay.io login steps, and the e2e-tests workflow removes its INFRACTL environment variable.

Changes: CI workflow updates

Layer / File(s) Summary
Build workflow registry credentials
.github/workflows/build-roxie-image.yml, .github/workflows/docker-build.yml
The workflows now use QUAY_RHACS_ENG_RW_USERNAME and QUAY_RHACS_ENG_RW_PASSWORD for Quay.io login.
End-to-end workflow configuration
.github/workflows/e2e-tests.yml, .github/workflows/e2e-tests-kind.yml
Both workflows remove the Quay.io login step. The e2e-tests workflow also removes the INFRACTL environment variable.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: mclasmeier

Merge Risk: Minimal · up to b1b23

This change switches CI image publishing to organization-shared Quay secrets and removes unneeded registry logins. No concrete defect was found. Confirm that the organization secrets are available to this repository before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the workflows now use organization-shared Quay secrets to push roxie's image. The raw summary confirms the login secrets switched in build-roxie-image.yml and docker-b…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the workflows now use organization-shared Quay secrets to push roxie's image. The raw summary confirms the login secrets switched in build-roxie-image.yml and docker-build.yml. It also shows removal of the Quay login and the INFRACTL variable in the e2e workflows. The title covers the primary change but not the removal of the INFRACTL variable or the e2e login steps, which is acceptable for a title. The title uses the conventional commit prefix and is specific.

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 77110ba and b1b232a.

Files selected for processing: 4

  • .github/workflows/build-roxie-image.yml
  • .github/workflows/docker-build.yml
  • .github/workflows/e2e-tests-kind.yml
  • .github/workflows/e2e-tests.yml
Files with no reviewable changes: 2

  • .github/workflows/e2e-tests-kind.yml
  • .github/workflows/e2e-tests.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@tommartensen
tommartensen force-pushed the tm/harmonize-quay-secrets branch from dbbc60e to b85e3ca Compare November 20, 2026 07:49
@tommartensen tommartensen changed the title chore: switch to org shared quay secrets for pushing and reading roxie's image chore: switch to org shared quay secrets for pushing roxie's image Nov 20, 2026
@tommartensen
tommartensen marked this pull request as ready for review November 20, 2026 09:19
@tommartensen
tommartensen enabled auto-merge (squash) November 20, 2026 09:21
@mclasmeier mclasmeier added the olm-tests If set, spawn an OpenShift cluster and run OLM tests against it. label Nov 20, 2026
@mclasmeier

Copy link
Copy Markdown
Collaborator

CI was green, triggered a re-run with the olm-tests label set.

@tommartensen

Copy link
Copy Markdown
Collaborator Author

triggered a re-run with the olm-tests label set.

--> anything I need to do now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

olm-tests If set, spawn an OpenShift cluster and run OLM tests against it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants