Repository navigation
Restore the WSL flag when install_cmdstan() returns early - #1336
Merged
Merged
Conversation
The Sys.unsetenv("CMDSTANR_USE_WSL") at the end undid a Sys.setenv()
at the top that the flag replaced in 2022.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.0 #1336 +/- ##
=======================================
Coverage ? 94.00%
=======================================
Files ? 19
Lines ? 9232
Branches ? 0
=======================================
Hits ? 8679
Misses ? 553
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CRAN stopped serving Windows binaries for R 4.1, so pak builds the current RcppParallel 6.2.1 from source, and its CMake TBB build rejects the 32-bit Rtools40 compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Restore the WSL flag when install_cmdstan() returns early
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: