Skip to content

Restore the WSL flag when install_cmdstan() returns early - #1336

Merged
jgabry merged 3 commits into
v1.0from
install-wsl-flag
Oct 20, 2026
Merged

jgabry merged 3 commits into
v1.0from
install-wsl-flag

Conversation

@jgabry

@jgabry jgabry commented Oct 19, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Restore the WSL flag when install_cmdstan() returns early

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

The Sys.unsetenv("CMDSTANR_USE_WSL") at the end undid a Sys.setenv()
at the top that the flag replaced in 2022.
@jgabry jgabry mentioned this pull request Oct 19, 2026
2 tasks done
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v1.0@c521ac6). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.0    #1336   +/-   ##
=======================================
  Coverage        ?   94.00%           
=======================================
  Files           ?       19           
  Lines           ?     9232           
  Branches        ?        0           
=======================================
  Hits            ?     8679           
  Misses          ?      553           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CRAN stopped serving Windows binaries for R 4.1, so pak builds the
current RcppParallel 6.2.1 from source, and its CMake TBB build rejects
the 32-bit Rtools40 compiler.
@jgabry
jgabry merged commit 70f963a into v1.0 Oct 20, 2026
19 checks passed
@jgabry
jgabry deleted the install-wsl-flag branch October 20, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants