Skip to content

[CMake 7/7] Add CMake builds and migrate the test runner and CI - #3506

Open
SteveBronder wants to merge 1 commit into
developfrom
cmake-split/06-cmake
Open

SteveBronder wants to merge 1 commit into
developfrom
cmake-split/06-cmake

Conversation

@SteveBronder

@SteveBronder SteveBronder commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add CMake builds for vendored dependencies, individual and grouped test executables, precompiled headers, standalone header checks, and generated probability/expression tests. Switch runTests.py, its Python build tools, Jenkins, and GitHub workflows together, and document the configuration/cache workflow. Keep Makefiles for upstream consumers. Clang test targets suppress unused-lambda-capture diagnostics so autodiff callbacks retain explicit captures.

Part 7 of the CMake migration split from #3463.

Depends on #3501, #3502, #3503, #3504, #3505. Also depends on #3508. Its base is fix/cvodes-adjoint-quadrature-output, so this review contains only the 22 infrastructure files. Merge the native stack from bottom to top.

Tests

  • Runner tests and varmat setup/error-handling tests pass.
  • GCC PCH and Ninja builds pass their test target.
  • All 13 retained Math headers compile standalone without PCH.
  • The combined stack passes 324 generated probability tests, 18 focused expression tests, seven two-rank MPI tests, and shuffled threaded/non-threaded core tests.
  • Dependency checks and Jenkins command capture pass.
  • Full GPU, Windows, documentation-build, and complete unit/probability matrices remain for CI.

Side Effects

CMake becomes the Math test runner and CI backend. Directory selections run grouped executables; individual source selections remain supported. The default ReleaseTesting configuration keeps assertions enabled. This PR targets the preceding CVODES solver-fix PR in the native stack.

Release notes

Add CMake as the backend for Math tests and CI.

Checklist

  • Copyright holder: Simons Foundation
  • The complete basic-test and CI matrix is passing
  • C++ idioms and Doxygen documentation have completed review
  • Focused validation is passing as described above; remaining coverage is listed

CI repair

The Windows x64 and ARM64 reverse-mode failures in run 41720340936 come from stale CVODES quadrature output. The fix and regression are reviewed separately in #3508, now the immediate prerequisite. This PR retains exactly its original 22-file infrastructure diff. The updated native Windows CI is pending.

Related PRs

Native stack: https://github.com/stan-dev/math/stack/3509

@SteveBronder
SteveBronder added this pull request to stack #3507 November 3, 2026 21:16
@SteveBronder
SteveBronder removed this pull request from stack #3507 November 4, 2026 16:44
@SteveBronder
SteveBronder changed the base branch from cmake-split/05-unit-tests to fix/cvodes-adjoint-quadrature-output November 4, 2026 16:44
@SteveBronder
SteveBronder added this pull request to stack #3509 November 4, 2026 16:44
@SteveBronder SteveBronder changed the title [CMake 6/6] Add CMake builds and migrate the test runner and CI [CMake 7/7] Add CMake builds and migrate the test runner and CI Nov 4, 2026
@SteveBronder
SteveBronder force-pushed the cmake-split/06-cmake branch 2 times, most recently from 0f38183 to 9e5813e Compare November 5, 2026 14:39
@WardBrian
WardBrian force-pushed the cmake-split/06-cmake branch 2 times, most recently from 71fe850 to 448bf03 Compare November 6, 2026 20:06
@WardBrian
WardBrian force-pushed the cmake-split/06-cmake branch from 448bf03 to eadfdb3 Compare November 13, 2026 12:42
@WardBrian
WardBrian force-pushed the cmake-split/06-cmake branch from eadfdb3 to d727559 Compare November 17, 2026 14:49
@SteveBronder
SteveBronder marked this pull request as ready for review November 17, 2026 18:34
@WardBrian
WardBrian force-pushed the cmake-split/06-cmake branch from d727559 to 0a799de Compare November 17, 2026 22:13
@SteveBronder

Copy link
Copy Markdown
Collaborator Author

fyi I'm still reviewing the cmake to make sure this makes sense

Base automatically changed from fix/cvodes-adjoint-quadrature-output to develop November 20, 2026 00:07
Add CMake targets for dependencies, individual and grouped tests, header
checks, and generated probability/expression tests. Migrate runTests.py,
Python test tools, Jenkins and GitHub CI together; document the workflow.

Retain Makefiles for upstream consumers. Preserve explicit callback
captures with a Clang test-only unused-capture warning exception.
Exclude unrelated numerical, solver and tolerance changes.
@WardBrian
WardBrian force-pushed the cmake-split/06-cmake branch from 0c3582e to d45a805 Compare November 20, 2026 00:07
@stan-buildbot

Copy link
Copy Markdown
Contributor
Name Old Result New Result Ratio Performance change( 1 - new / old )
stat_comp_benchmarks/benchmarks/low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.99 -0.86% slower
stat_comp_benchmarks/benchmarks/irt_2pl/irt_2pl.stan 4.37 4.38 1.0 -0.26% slower
stat_comp_benchmarks/benchmarks/pkpd/one_comp_mm_elim_abs.stan 18.04 18.07 1.0 -0.2% slower
stat_comp_benchmarks/benchmarks/pkpd/sim_one_comp_mm_elim_abs.stan 0.23 0.23 1.02 1.51% faster
stat_comp_benchmarks/benchmarks/low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.44 8.43 1.0 0.21% faster
stat_comp_benchmarks/benchmarks/gp_regr/gp_regr.stan 0.1 0.1 1.01 0.83% faster
stat_comp_benchmarks/benchmarks/gp_regr/gen_gp_data.stan 0.02 0.02 0.99 -0.61% slower
stat_comp_benchmarks/benchmarks/eight_schools/eight_schools.stan 0.06 0.06 1.03 3.19% faster
stat_comp_benchmarks/benchmarks/low_dim_gauss_mix/low_dim_gauss_mix.stan 2.71 2.71 1.0 -0.04% slower
stat_comp_benchmarks/benchmarks/arK/arK.stan 1.56 1.56 1.0 -0.12% slower
stat_comp_benchmarks/benchmarks/sir/sir.stan 87.25 87.02 1.0 0.27% faster
stat_comp_benchmarks/benchmarks/garch/garch.stan 0.44 0.44 0.99 -0.7% slower
stat_comp_benchmarks/benchmarks/gp_pois_regr/gp_pois_regr.stan 2.25 2.24 1.01 0.65% faster
stat_comp_benchmarks/benchmarks/arma/arma.stan 0.28 0.29 0.98 -1.57% slower
performance.compilation 229.59 226.01 1.02 1.56% faster
Mean result: 1.0027096486448768

Jenkins Console Log
Jenkins Build Stages
Commit hash: f3e34a380c53994be9185c281552fa9dd4ff3af8

Machine information
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.3 LTS
Release:	20.04
Codename:	focal

CPU:

Architecture:                            x86_64
CPU op-mode(s):                          32-bit, 64-bit
Byte Order:                              Little Endian
Address sizes:                           46 bits physical, 48 bits virtual
CPU(s):                                  80
On-line CPU(s) list:                     0-79
Thread(s) per core:                      2
Core(s) per socket:                      20
Socket(s):                               2
NUMA node(s):                            2
Vendor ID:                               GenuineIntel
CPU family:                              6
Model:                                   85
Model name:                              Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz
Stepping:                                7
CPU MHz:                                 1000.031
CPU max MHz:                             3900.0000
CPU min MHz:                             1000.0000
BogoMIPS:                                5000.00
L1d cache:                               1.3 MiB
L1i cache:                               1.3 MiB
L2 cache:                                40 MiB
L3 cache:                                55 MiB
NUMA node0 CPU(s):                       0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s):                       1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling:      Mitigation; Microcode
Vulnerability Indirect target selection: Mitigation; Aligned branch/return thunks
Vulnerability Itlb multihit:             KVM: Mitigation: VMX unsupported
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Old microcode:             Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; Enhanced / Automatic IBRS; IBPB conditional; PBRSB-eIBRS SW sequence; BHI SW loop, KVM SW loop
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Mitigation; TSX disabled
Vulnerability Vmscape:                   Mitigation; IBPB before exit to userspace
Flags:                                   fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke avx512_vnni md_clear flush_l1d arch_capabilities

G++:

g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:

clang version 10.0.0-4ubuntu1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants