Repository navigation
[RenameFile] Never overwrite or delete files; fix null job queue crash - #799
Open
dude-stash wants to merge 3 commits into
Open
dude-stash wants to merge 3 commits into
dude-stash wants to merge 3 commits into
Conversation
job_queue() can return None, which crashed every taskQueue helper except tooManyScanOnTaskQueue. Normalise it to an empty list, and fix the missing f-string in the plugin-task job match. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
rename()/move() silently overwrite an existing target, so two files of one scene that resolved to the same new name lost one of them. Pick a free 'name (N)' (checking associated files too) and drop both os.remove calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dude-stash
force-pushed
the
fix/renamefile-null-taskqueue
branch
from
October 18, 2026 02:31
9adffe5 to
3ba544b
Compare
The limit lived in add_tag(), which nothing calls; getTags() joined every tag. Apply the limit (and -1 for none) in getTags(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
dude-stash
force-pushed
the
fix/renamefile-null-taskqueue
branch
from
October 18, 2026 02:38
3ba544b to
3fbc1bc
Compare
|
This pull request has been mentioned on Stash Forum. There might be relevant details there: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #798
taskQueuetreats aNonejob queue as empty, which fixes the'NoneType' object is not iterablecrash.fprefix inisRunningPluginTaskJobOnTaskQueue.name (2),name (3), ... instead of renaming over it. This happens on scenes with two files: the plugin only renamesfiles[0], and its computed name can match the other file's existing name, which the rename then overwrote. A case-only rename of the same file is still allowed.os.removecalls. A failed rename now leaves the original file in place.getTags(). It was only enforced inadd_tag(), which is never called, so every tag was always added.Checked: the numbering and tag-limit logic on temp data, and confirmed in Stash that the second file of a two-file scene now gets
name (2)instead of overwriting the first.Not covered: renaming every file of a multi-file scene. The plugin still only renames
files[0].AI disclosure: this was written with Claude Code.
🤖 Generated with Claude Code