chore: clean-up - #14413
Merged
Merged
Conversation
Propagates fix from 82ee27d ("bench: generate arrays with `NaN` values") to the remaining masked sibling packages whose benchmarks generate input arrays which never contain `NaN` values, meaning the `NaN` code path of the benchmarked NaN-ignoring reductions is never exercised. Affected packages: - stats/base/ndarray/nanmskmax - stats/base/ndarray/nanmskmidrange - stats/base/ndarray/nanmskmin - stats/base/ndarray/nanmskrange - stats/base/ndarray/snanmskmax - stats/base/ndarray/snanmskmaxabs - stats/base/ndarray/snanmskmidrange - stats/base/ndarray/snanmskmin - stats/base/ndarray/snanmskminabs - stats/base/ndarray/snanmskrange
Propagates fix from 746050a ("chore: remove unused header") to sibling packages whose C examples include `<time.h>` without using any of its declarations. Affected packages: - stats/base/dists/normal/cdf - stats/base/dists/normal/logpdf
Propagates fix from 72b23ea ("chore: clean-up") to remaining files using "floating point" as an unhyphenated compound modifier, which is contrary to project convention. Affected packages: - math/base/special (namespace README) - math/base/special/cbrt - math/base/special/kernel-log1p - math/base/special/kernel-log1pf - math/base/special/log1p - math/base/special/rempio2 - math/base/special/rempio2f - string/format The occurrences in `string/format` example input/output literals are deliberately left unchanged.
Touching `string/format/README.md` triggers doctest runs in CI which fail on pre-existing displayed-return-value mismatches unrelated to this propagation. The single prose edit is dropped to keep the pull request self-contained; the pre-existing doctest failures should be addressed separately.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Comment-only hyphenation edits to `lib/main.js` and `src/main.c` in
`math/base/special/{cbrt,log1p,kernel-log1p,kernel-log1pf}` mark those
packages as changed, and their combined dependent set (126+ packages)
makes the affected-tests CI job fail with "Argument list too long"
before any test runs. The edits are dropped to keep CI green; the
remaining changed packages have a bounded dependent set.
kgryte
marked this pull request as ready for review
August 20, 2026 02:15
kgryte
approved these changes
Aug 20, 2026
develop fixes to sibling packages (2026-08-19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-08-18 17:33 (−07:00) and 2026-08-19 05:08 (−07:00) (fd16a2f49…dd78acd51) to sibling packages.This pull request:
82ee27d— benchmark arrays withoutNaNvaluesFixes
benchmark/benchmark.jsin ten masked reduction packages, mirroring the same migration already applied todnanmskmaxin #14402: input arrays are generated viafillBy( zeros( [ len ], options ), rand )withNaNinjected at a 0.2 rate throughbernoulli, rather than drawing exclusively from aNaN-free distribution. WithoutNaNvalues present, benchmarks forNaN-aware masked reductions never exercise theNaN-handling branch, so timings do not reflect real-world usage. Mask generation is unchanged and continues to use the template'smrandhelper.stats/base/ndarray/nanmskmaxstats/base/ndarray/nanmskmidrangestats/base/ndarray/nanmskminstats/base/ndarray/nanmskrangestats/base/ndarray/snanmskmaxstats/base/ndarray/snanmskmaxabsstats/base/ndarray/snanmskmidrangestats/base/ndarray/snanmskminstats/base/ndarray/snanmskminabsstats/base/ndarray/snanmskrange746050a— unused<time.h>include in C examples746050adropped the unused#include <time.h>from thewaldC examples, which callrand()but never touchtime(),srand(), orclock(). A repo-wide search surfaced two sites still carrying the same dead include; this PR removes it there, matching the corresponding README examples, which never had it.stats/base/dists/normal/cdfstats/base/dists/normal/logpdf72b23ea— unhyphenatedfloating pointcompound modifiersFixes remaining unhyphenated "floating point" occurrences left after
72b23ea, applying the same "floating-point" convention to test descriptions and README prose that PR did not touch. Excludes dataset corpus files and further sites noted below.math/base/special/rempio2math/base/special/rempio2fmath/base/special(namespace README)Related Issues
No.
Questions
No.
Other
Validation. Candidate sites were enumerated via structural search signatures scoped to the source patterns' namespaces (
stats/base/ndarray/*nan*benchmarks; repo-wide#include <time.h>withouttime()/srand()/clock()usage; repo-widefloating point <noun>). Every site was independently confirmed by two validation passes reading each file in full, an adaptation pass producing per-site patches (verified byte-identical to the revieweddnanmskmaxtemplate modulo package name, dtype, and pre-existing per-file conventions), and a style-consistency pass againstdocs/style-guides. Deliberately excluded:string/formatREADME example input/output literals, dataset corpus files underdatasets/spam-assassin, sibling repl.txt/JSDoc wording sites fromdcb03da(semantics differ per site), and the empty notes-section/[mgf]-link additions from4df94c4(template-conformance enhancements, not defects).Post-push drops (CI-driven). Two sets of hyphenation edits were initially included and then reverted:
string/format/README.md(e69dd2a1f): touching the file triggers doctest runs which fail on pre-existing displayed-return-value mismatches in that README (blocks at lines 93–125, 162–178, and 213–230), unrelated to this propagation. Those doctest failures exist ondevelopand should be addressed separately.math/base/special/{cbrt,log1p,kernel-log1p,kernel-log1pf}lib/main.js/src/main.ccomments (1c0fe9ce8): the affected-tests CI job computes the dependent set of every changed package, andcbrt(77 dependents) pluslog1p(49 dependents) push the batchedmake test-javascript-files-mininvocation pastARG_MAX, failing with "Argument list too long" before any test runs. Thexargsbatching in.github/workflows/scripts/run_affected_tests/rundoes not protect against expansion inside the make recipe — likely worth a separate CI fix, after which the eight one-line comment edits can be propagated.One commit per source fix pattern; each commit body cites the source SHA.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This draft PR was produced by an automated Claude Code fix-propagation routine: it identified generalizable fixes merged to
developin the last 24 hours, located sibling packages with the same defects, and applied the equivalent fixes after multi-pass validation. All changes should be reviewed by a maintainer before promotion from draft.@stdlib-js/reviewers