Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jsonpointer.py
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ def __eq__(self, other):
"""

if not isinstance(other, JsonPointer):
return False
return NotImplemented

return self.parts == other.parts

Expand Down
17 changes: 17 additions & 0 deletions tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,23 @@ def test_eq_hash(self):
# a pointer compares not-equal to objects of other types
self.assertFalse(p1 == "/something/1/b")

def test_other_types_remain_unequal(self):
for other in ["/a/b/c", None, 1, object()]:
for left, right in [(self.ptr1, other), (other, self.ptr1)]:
with self.subTest(left=left, right=right):
self.assertFalse(left == right)
self.assertTrue(left != right)

def test_reflected_equality(self):
for left, right in [(self.ptr1, mock.ANY), (mock.ANY, self.ptr1)]:
with self.subTest(left=left, right=right):
self.assertTrue(left == right)

def test_reflected_inequality(self):
for left, right in [(self.ptr1, mock.ANY), (mock.ANY, self.ptr1)]:
with self.subTest(left=left, right=right):
self.assertFalse(left != right)

def test_contains(self):
self.assertTrue(self.ptr1.contains(self.ptr2))
self.assertTrue(self.ptr1.contains(self.ptr1))
Expand Down
Loading