Repository navigation
Exit with status 130 when the CLI is interrupted - #124
Merged
stefankoegl merged 4 commits intoNov 11, 2026
Merged
Conversation
Ctrl-C made jsonpointer exit with 1, the same status as "pointer could not be resolved", so callers could not tell the two apart. Use 130 (128 + SIGINT), the conventional status for an interrupted command, and document it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PewzpjhRBV84QNbKy9H564
runpy.run_path() returns a copy of the script's globals, so replacing resolve_files in it had no effect on main(). Raise KeyboardInterrupt from json.load() instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PewzpjhRBV84QNbKy9H564
argparse.FileType is deprecated since Python 3.14. Open the pointer file and the JSON inputs with a small helper instead, which keeps the existing behaviour: - "-" still means standard input, which is never closed - files are read as UTF-8 - a file that cannot be opened is a usage error (exit status 2) with the same "can't open" message The pointer file is now opened after argument parsing rather than during it, so the help output is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PewzpjhRBV84QNbKy9H564
Stop using the deprecated argparse.FileType in the CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #114. Once that merges, retarget this to
master. This is the first PR in the CLI/packaging stack: this PR, then FileType, then pyproject, then the entry point.On Ctrl-C,
jsonpointerexited with 1, the same status as "pointer could not be resolved", so scripts couldn't tell the two apart. It now exits with 130 (128 + SIGINT), the usual status for an interrupted command. The exit statuses indoc/commandline.rstare updated to match.This is a behaviour change for anyone who checks for status 1 after an interrupt.
There's a new test for it. I confirmed it fails with the old exit code and passes with the new one.
python -m unittest, flake8 and the docs build pass.Generated by Claude Code