Repository navigation
Stop adding the restore resource fee twice in the JS and Python examples - #3160
theluckystrike wants to merge 2 commits into
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
|
🤖 Automated message from the Stellar Triage Bot. Hi @theluckystrike, thanks for the PR. I saw it, but I review only when someone calls me in. A maintainer will look at it. How to reach me:
|
|
/triage |
|
🤖 Automated message from the Stellar Triage Bot. Reviewing because @kaankacar asked with /triage. Verified: Not run: the JS and Python restore snippets on both pages. No live preview was available. External-origin change, so a maintainer merges this. What I checked
|
Closes #3134
TransactionBuilder.build()already adds the Soroban data's resource fee to the fee (js-stellar-sdksrc/base/transaction_builder.ts:1042, py-stellar-basestellar_sdk/transaction_builder.py:152). The restore examples also addedminResourceFeeby hand, so the fee bid counted it twice.Changes, same in both pages:
build()adds the resource fee, like the Java tabs from Add Java examples to the learn pages #3133.feeoption fromcloneFrom.cloneFromalready removes the old resource fee before it derives the base fee, andbuild()adds the new one fromsim.transactionData.Docs only, 2 files. I checked each line against the SDK source on main. I did not run the snippets against testnet.