Repository navigation
Sign-extend 1-byte signed integer device attributes - #500
Merged
Merged
Conversation
The master read a 1-byte signed integer attribute as unsigned, so -1 came back as 255. The outstation sends values from -128 to 126 in one byte, so the library's own master and outstation disagreed. Read the byte with u8::cast_signed, which needs Rust 1.87, so raise the minimum supported Rust version from 1.85 to 1.87. Clippy's manual_is_multiple_of lint applies at 1.87, so use is_multiple_of in the two places it flags. Closes #497.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #497.