Fixes corner case where strict mode isn't working when JSONTokener's next() and back() are called first - #1074
Open
XIAYM-gh wants to merge 2 commits into
Open
Fixes corner case where strict mode isn't working when JSONTokener's next() and back() are called first#1074XIAYM-gh wants to merge 2 commits into
XIAYM-gh wants to merge 2 commits into
Conversation
…next() and back() are called first
Owner
|
@XIAYM-gh I will resolve the sonarqube issues separately, you can ignore them |
stleary
reviewed
Sep 3, 2026
stleary
reviewed
Sep 3, 2026
stleary
reviewed
Sep 3, 2026
stleary
reviewed
Sep 3, 2026
stleary
reviewed
Sep 3, 2026
Contributor
Author
|
Thanks for noticing! I'll start working on this in a few hours. (it's 5:21 AM in my timezone right now, and probably I will sleep more) |
|
Contributor
Author
|
The problems should be settled now. Please review the new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #944, where strict mode syntax check isn't working when next() and back() are called first.
ctors are modified, but the backward compatibility is kept.
Besides, I've added
isAtStart()inJSONTokener, which shouldn't be a compatibility issue :)All tests had passed. Thanks ahead for reviewing this!