Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2380.
Strict Mode replays effect setup/cleanup/setup. The first cleanup left the shared
mountedflag false, so the new geolocation watcher could never finish loading. Keep the flag and callbacks local to each effect setup; callbacks from a cleaned-up watcher stay inactive.Validation:
createRoot+StrictModereproduction: baseline staysloading: true, patched source updates tofalse.tsc --noEmit, changed-file ESLint (one existing options dependency warning) and Prettier pass.The committed tests simulate effect replay using the repository's React 17 renderer. No dependency upgrade is included. Investigation, patch and tests are AI-assisted.