Skip to content

feat: support producer batching configuration - #848

Open
freeznet wants to merge 1 commit into
masterfrom
freeznet/function-batching-config
Open

feat: support producer batching configuration#848
freeznet wants to merge 1 commit into
masterfrom
freeznet/function-batching-config

Conversation

@freeznet

Copy link
Copy Markdown
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Aug 20, 2026
Copilot AI lite review requested due to automatic review settings August 20, 2026 14:57
@freeznet
freeznet requested a review from a team as a code owner August 20, 2026 14:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions Bot added the doc-info-missing This pr needs to mark a document option in description label Aug 20, 2026

@jiangpengcheng jiangpengcheng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One runner-compatibility issue must be addressed before merge. See the inline finding.

Comment thread controllers/spec/utils.go
batchingMaxPublishDelayMs = 10
}

return &proto.BatchingSpec{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Do not emit batchingSpec without defining a compatible runner baseline.

The repository builds and tests runners from streamnative/sn-platform:3.2.2.1, whose Function.proto does not contain ProducerSpec.batchingSpec. Its Java and Python runners reject unknown JSON fields while parsing --function_details, so setting batchingConfig makes the pod exit before user code starts. The added tests only validate the operator-side proto and cannot catch this incompatibility.

Please add an E2E test using a PIP-401-capable runner and document/enforce the minimum runner version—upstream Pulsar 4.1+—or update the supported runner baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants