feat: support producer batching configuration - #848
Conversation
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
jiangpengcheng
left a comment
There was a problem hiding this comment.
One runner-compatibility issue must be addressed before merge. See the inline finding.
| batchingMaxPublishDelayMs = 10 | ||
| } | ||
|
|
||
| return &proto.BatchingSpec{ |
There was a problem hiding this comment.
[P1] Do not emit batchingSpec without defining a compatible runner baseline.
The repository builds and tests runners from streamnative/sn-platform:3.2.2.1, whose Function.proto does not contain ProducerSpec.batchingSpec. Its Java and Python runners reject unknown JSON fields while parsing --function_details, so setting batchingConfig makes the pod exit before user code starts. The added tests only validate the operator-side proto and cannot catch this incompatibility.
Please add an E2E test using a PIP-401-capable runner and document/enforce the minimum runner version—upstream Pulsar 4.1+—or update the supported runner baseline.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)