fix: align spend request amount cap with the published $500 limit - #256
Open
EfeDurmaz16 wants to merge 1 commit into
Open
fix: align spend request amount cap with the published $500 limit#256EfeDurmaz16 wants to merge 1 commit into
EfeDurmaz16 wants to merge 1 commit into
Conversation
The published per-request maximum is 50,000 cents, but createOptions still allows 500,000 and CLAUDE.md still documents the old number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#251 lowered the published per-request maximum to 50,000 cents. The client still accepts 500,000.
README.md:290skills/create-payment-credential/SKILL.md:326CLAUDE.md:80schema.ts:33spend-request create --amount 400000passes local validation today and fails at the API instead. Catching it locally is what the schema is for. #251 also dropped the number from the.describe()string, so--schemaoutput no longer states any limit at all.CLAUDE.md asks for README, SKILL.md, the schema description and CLAUDE.md to move together. This brings along the two that were left behind.
Change
createOptions.amountmax 500000 to 50000If the per-request maximum is still $5,000 and only the daily limit moved to $500, say so and I will flip this into a docs revert instead.